dmaengine: ioat: Fix error handling path

tititiou36 · Vinod Koul · commit 5c9afbda911c · 2017-11-29T19:47:46.000+05:30
If the last test in 'ioat_dma_self_test()' fails, we must release all
the allocated resources and not just part of them.

Signed-off-by: Christophe JAILLET &lt;christophe.jaillet@wanadoo.fr&gt;
Acked-by: Dave Jiang &lt;dave.jiang@intel.com&gt;
Signed-off-by: Vinod Koul &lt;vinod.koul@intel.com&gt;
diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c
@@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)
 	if (memcmp(src, dest, IOAT_TEST_SIZE)) {
 		dev_err(dev, "Self-test copy failed compare, disabling\n");
 		err = -ENODEV;
-		goto free_resources;
+		goto unmap_dma;
 	}
 
 unmap_dma:

Original file line number	Diff line number	Diff line change
`@@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device *ioat_dma)`
`390`	`390`	`if (memcmp(src, dest, IOAT_TEST_SIZE)) {`
`391`	`391`	`dev_err(dev, "Self-test copy failed compare, disabling\n");`
`392`	`392`	`err = -ENODEV;`
`393`		`- goto free_resources;`
	`393`	`+ goto unmap_dma;`
`394`	`394`	`}`
`395`	`395`
`396`	`396`	`unmap_dma:`