Skip to content

Commit 6892286

Browse files
committed
tcp: Do not reload skb pointer after skb_gro_receive().
This is not necessary. skb_gro_receive() will never change what 'head' points to. In it's original implementation (see commit 71d93b3 ("net: Add skb_gro_receive")), it did: ==================== + *head = nskb; + nskb->next = p->next; + p->next = NULL; ==================== This sequence was removed in commit 58025e4 ("net: gro: remove obsolete code from skb_gro_receive()") Signed-off-by: David S. Miller <[email protected]> Signed-off-by: Eric Dumazet <[email protected]>
1 parent 0ca69d1 commit 6892286

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

net/ipv4/tcp_offload.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -268,8 +268,6 @@ struct sk_buff **tcp_gro_receive(struct sk_buff **head, struct sk_buff *skb)
268268
goto out_check_final;
269269
}
270270

271-
p = *head;
272-
th2 = tcp_hdr(p);
273271
tcp_flag_word(th2) |= flags & (TCP_FLAG_FIN | TCP_FLAG_PSH);
274272

275273
out_check_final:

0 commit comments

Comments
 (0)