driver core: add __printf verification to device_create_groups_vargs

malaterre · gregkh · commit 6a8b55d7f226 · 2018-05-14T16:59:21.000+02:00
__printf is useful to verify format and arguments. Remove the following
warning (with W=1):

  drivers/base/core.c:2435:2: warning: function might be possible candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]

Signed-off-by: Mathieu Malaterre &lt;malat@debian.org&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/base/core.c b/drivers/base/core.c
@@ -2411,7 +2411,7 @@ static void device_create_release(struct device *dev)
 	kfree(dev);
 }
 
-static struct device *
+static __printf(6, 0) struct device *
 device_create_groups_vargs(struct class *class, struct device *parent,
 			   dev_t devt, void *drvdata,
 			   const struct attribute_group **groups,

Original file line number	Diff line number	Diff line change
`@@ -2411,7 +2411,7 @@ static void device_create_release(struct device *dev)`
`2411`	`2411`	`kfree(dev);`
`2412`	`2412`	`}`
`2413`	`2413`
`2414`		`-static struct device *`
	`2414`	`+static __printf(6, 0) struct device *`
`2415`	`2415`	`device_create_groups_vargs(struct class class, struct device parent,`
`2416`	`2416`	`dev_t devt, void *drvdata,`
`2417`	`2417`	`const struct attribute_group **groups,`