Skip to content

Commit 743d1ef

Browse files
committed
USB: gadget: udc: renesas_usb3: no need to check return value of debugfs_create functions
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Felipe Balbi <[email protected]> Cc: Simon Horman <[email protected]> Cc: Geert Uytterhoeven <[email protected]> Acked-by: Yoshihiro Shimoda <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent edbeb6b commit 743d1ef

File tree

1 file changed

+3
-15
lines changed

1 file changed

+3
-15
lines changed

drivers/usb/gadget/udc/renesas_usb3.c

Lines changed: 3 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2391,22 +2391,10 @@ static const struct file_operations renesas_usb3_b_device_fops = {
23912391
static void renesas_usb3_debugfs_init(struct renesas_usb3 *usb3,
23922392
struct device *dev)
23932393
{
2394-
struct dentry *root, *file;
2394+
usb3->dentry = debugfs_create_dir(dev_name(dev), NULL);
23952395

2396-
root = debugfs_create_dir(dev_name(dev), NULL);
2397-
if (IS_ERR_OR_NULL(root)) {
2398-
dev_info(dev, "%s: Can't create the root\n", __func__);
2399-
return;
2400-
}
2401-
2402-
file = debugfs_create_file("b_device", 0644, root, usb3,
2403-
&renesas_usb3_b_device_fops);
2404-
if (!file) {
2405-
dev_info(dev, "%s: Can't create debugfs mode\n", __func__);
2406-
debugfs_remove_recursive(root);
2407-
} else {
2408-
usb3->dentry = root;
2409-
}
2396+
debugfs_create_file("b_device", 0644, usb3->dentry, usb3,
2397+
&renesas_usb3_b_device_fops);
24102398
}
24112399

24122400
/*------- platform_driver ------------------------------------------------*/

0 commit comments

Comments
 (0)