Skip to content

Commit 7b778ae

Browse files
Rafał Miłeckidavem330
authored andcommitted
net: broadcom: bcm4908_enet: drop "inline" from C functions
It seems preferred to let compiler optimize code if applicable. While at it drop unused enet_umac_maskset(). Suggested-by: Andrew Lunn <[email protected]> Signed-off-by: Rafał Miłecki <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Florian Fainelli <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent af263af commit 7b778ae

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

drivers/net/ethernet/broadcom/bcm4908_enet.c

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,17 +75,17 @@ struct bcm4908_enet {
7575
* R/W ops
7676
*/
7777

78-
static inline u32 enet_read(struct bcm4908_enet *enet, u16 offset)
78+
static u32 enet_read(struct bcm4908_enet *enet, u16 offset)
7979
{
8080
return readl(enet->base + offset);
8181
}
8282

83-
static inline void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value)
83+
static void enet_write(struct bcm4908_enet *enet, u16 offset, u32 value)
8484
{
8585
writel(value, enet->base + offset);
8686
}
8787

88-
static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
88+
static void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
8989
{
9090
u32 val;
9191

@@ -96,27 +96,22 @@ static inline void enet_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask,
9696
enet_write(enet, offset, val);
9797
}
9898

99-
static inline void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set)
99+
static void enet_set(struct bcm4908_enet *enet, u16 offset, u32 set)
100100
{
101101
enet_maskset(enet, offset, set, set);
102102
}
103103

104-
static inline u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset)
104+
static u32 enet_umac_read(struct bcm4908_enet *enet, u16 offset)
105105
{
106106
return enet_read(enet, ENET_UNIMAC + offset);
107107
}
108108

109-
static inline void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value)
109+
static void enet_umac_write(struct bcm4908_enet *enet, u16 offset, u32 value)
110110
{
111111
enet_write(enet, ENET_UNIMAC + offset, value);
112112
}
113113

114-
static inline void enet_umac_maskset(struct bcm4908_enet *enet, u16 offset, u32 mask, u32 set)
115-
{
116-
enet_maskset(enet, ENET_UNIMAC + offset, mask, set);
117-
}
118-
119-
static inline void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
114+
static void enet_umac_set(struct bcm4908_enet *enet, u16 offset, u32 set)
120115
{
121116
enet_set(enet, ENET_UNIMAC + offset, set);
122117
}

0 commit comments

Comments
 (0)