Skip to content

Commit 861d75d

Browse files
committed
Merge branch 'for-4.9-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
Pull libata fixes from Tejun Heo: "This is quite late but SCT Write Same support added during this cycle is broken subtly but seriously and it'd be best to disable it before v4.9 gets released. This contains two commits - one low impact sata_mv fix and the mentioned disabling of SCT Write Same" * 'for-4.9-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata: libata-scsi: disable SCT Write Same for the moment ata: sata_mv: check for errors when parsing nr-ports from dt
2 parents af9468d + e185934 commit 861d75d

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

drivers/ata/libata-scsi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,6 +1159,7 @@ static void ata_scsi_sdev_config(struct scsi_device *sdev)
11591159
{
11601160
sdev->use_10_for_rw = 1;
11611161
sdev->use_10_for_ms = 1;
1162+
sdev->no_write_same = 1;
11621163

11631164
/* Schedule policy is determined by ->qc_defer() callback and
11641165
* it needs to see every deferred qc. Set dev_blocked to 1 to

drivers/ata/sata_mv.c

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4090,7 +4090,20 @@ static int mv_platform_probe(struct platform_device *pdev)
40904090

40914091
/* allocate host */
40924092
if (pdev->dev.of_node) {
4093-
of_property_read_u32(pdev->dev.of_node, "nr-ports", &n_ports);
4093+
rc = of_property_read_u32(pdev->dev.of_node, "nr-ports",
4094+
&n_ports);
4095+
if (rc) {
4096+
dev_err(&pdev->dev,
4097+
"error parsing nr-ports property: %d\n", rc);
4098+
return rc;
4099+
}
4100+
4101+
if (n_ports <= 0) {
4102+
dev_err(&pdev->dev, "nr-ports must be positive: %d\n",
4103+
n_ports);
4104+
return -EINVAL;
4105+
}
4106+
40944107
irq = irq_of_parse_and_map(pdev->dev.of_node, 0);
40954108
} else {
40964109
mv_platform_data = dev_get_platdata(&pdev->dev);

0 commit comments

Comments
 (0)