Skip to content

Commit b701cac

Browse files
Matt TurnerJeff Kirsher
authored andcommitted
e1000e: Set HTHRESH when PTHRESH is used
According to section 12.0.3.4.13 "Receive Descriptor Control - RXDCTL" of the Intel® 82579 Gigabit Ethernet PHY Datasheet v2.1: "HTHRESH should be given a non zero value when ever PTHRESH is used." In RXDCTL(0), PTHRESH lives at bits 5:0, and HTHREST lives at bits 13:8. Set only bit 8 of HTHREST as is done in e1000_flush_rx_ring(). Found by inspection. Signed-off-by: Matt Turner <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 28cb2d1 commit b701cac

File tree

1 file changed

+1
-1
lines changed
  • drivers/net/ethernet/intel/e1000e

1 file changed

+1
-1
lines changed

drivers/net/ethernet/intel/e1000e/netdev.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3303,7 +3303,7 @@ static void e1000_configure_rx(struct e1000_adapter *adapter)
33033303
if (adapter->flags & FLAG_IS_ICH) {
33043304
u32 rxdctl = er32(RXDCTL(0));
33053305

3306-
ew32(RXDCTL(0), rxdctl | 0x3);
3306+
ew32(RXDCTL(0), rxdctl | 0x3 | BIT(8));
33073307
}
33083308

33093309
pm_qos_update_request(&adapter->pm_qos_req, lat);

0 commit comments

Comments
 (0)