Skip to content

Commit d33d5a6

Browse files
committed
avoid spurious "may be used uninitialized" warning
The timer type simplifications caused a new gcc warning: drivers/base/power/domain.c: In function ‘genpd_runtime_suspend’: drivers/base/power/domain.c:562:14: warning: ‘time_start’ may be used uninitialized in this function [-Wmaybe-uninitialized] elapsed_ns = ktime_to_ns(ktime_sub(ktime_get(), time_start)); despite the actual use of "time_start" not having changed in any way. It appears that simply changing the type of ktime_t from a union to a plain scalar type made gcc check the use. The variable wasn't actually used uninitialized, but gcc apparently failed to notice that the conditional around the use was exactly the same as the conditional around the initialization of that variable. Add an unnecessary initialization just to shut up the compiler. Signed-off-by: Linus Torvalds <[email protected]>
1 parent 3ddc76d commit d33d5a6

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/base/power/domain.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -544,6 +544,7 @@ static int genpd_runtime_suspend(struct device *dev)
544544
return -EBUSY;
545545

546546
/* Measure suspend latency. */
547+
time_start = 0;
547548
if (runtime_pm)
548549
time_start = ktime_get();
549550

0 commit comments

Comments
 (0)