Skip to content

Commit d95cd48

Browse files
kuchtamJeff Kirsher
authored andcommitted
i40e: Fix for blinking activity instead of link LEDs
This fix solves an issue occurring while calling i40e_led_set function from the driver with "blink" parameter set as TRUE. This call resulted in Activity LED blinking instead of Link LED, which may lead to errors in physically identifying the port, since Activity LED may be blinking for different reasons as well. Signed-off-by: Michal Kuchta <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 06aa040 commit d95cd48

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/net/ethernet/intel/i40e/i40e_common.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1486,6 +1486,7 @@ u32 i40e_led_get(struct i40e_hw *hw)
14861486
case I40E_COMBINED_ACTIVITY:
14871487
case I40E_FILTER_ACTIVITY:
14881488
case I40E_MAC_ACTIVITY:
1489+
case I40E_LINK_ACTIVITY:
14891490
continue;
14901491
default:
14911492
break;
@@ -1534,6 +1535,7 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
15341535
case I40E_COMBINED_ACTIVITY:
15351536
case I40E_FILTER_ACTIVITY:
15361537
case I40E_MAC_ACTIVITY:
1538+
case I40E_LINK_ACTIVITY:
15371539
continue;
15381540
default:
15391541
break;
@@ -1544,9 +1546,6 @@ void i40e_led_set(struct i40e_hw *hw, u32 mode, bool blink)
15441546
gpio_val |= ((mode << I40E_GLGEN_GPIO_CTL_LED_MODE_SHIFT) &
15451547
I40E_GLGEN_GPIO_CTL_LED_MODE_MASK);
15461548

1547-
if (mode == I40E_LINK_ACTIVITY)
1548-
blink = false;
1549-
15501549
if (blink)
15511550
gpio_val |= BIT(I40E_GLGEN_GPIO_CTL_LED_BLINK_SHIFT);
15521551
else

0 commit comments

Comments
 (0)