Skip to content

Commit ec5d241

Browse files
mszyprowjoergroedel
authored andcommitted
iommu/exynos: Improve page fault debug message
Add master device name to default IOMMU fault message to make easier to find which device triggered the fault. While at it, move printing some information (like page table base and first level entry addresses) to dev_dbg(), because those are typically not very useful for typical device driver user/developer not equipped with hardware debugging tools. Signed-off-by: Marek Szyprowski <[email protected]> Signed-off-by: Joerg Roedel <[email protected]>
1 parent 2f5f44f commit ec5d241

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

drivers/iommu/exynos-iommu.c

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -381,13 +381,14 @@ static void show_fault_information(struct sysmmu_drvdata *data,
381381
{
382382
sysmmu_pte_t *ent;
383383

384-
dev_err(data->sysmmu, "%s FAULT occurred at %#x (page table base: %pa)\n",
385-
finfo->name, fault_addr, &data->pgtable);
384+
dev_err(data->sysmmu, "%s: %s FAULT occurred at %#x\n",
385+
dev_name(data->master), finfo->name, fault_addr);
386+
dev_dbg(data->sysmmu, "Page table base: %pa\n", &data->pgtable);
386387
ent = section_entry(phys_to_virt(data->pgtable), fault_addr);
387-
dev_err(data->sysmmu, "\tLv1 entry: %#x\n", *ent);
388+
dev_dbg(data->sysmmu, "\tLv1 entry: %#x\n", *ent);
388389
if (lv1ent_page(ent)) {
389390
ent = page_entry(ent, fault_addr);
390-
dev_err(data->sysmmu, "\t Lv2 entry: %#x\n", *ent);
391+
dev_dbg(data->sysmmu, "\t Lv2 entry: %#x\n", *ent);
391392
}
392393
}
393394

0 commit comments

Comments
 (0)