Skip to content

Commit f59c303

Browse files
linuswolofj
authored andcommitted
ARM: Fix i2c-gpio GPIO descriptor tables
I used bad names in my clumsiness when rewriting many board files to use GPIO descriptors instead of platform data. A few had the platform_device ID set to -1 which would indeed give the device name "i2c-gpio". But several had it set to >=0 which gives the names "i2c-gpio.0", "i2c-gpio.1" ... Fix the offending instances in the ARM tree. Sorry for the mess. Fixes: b2e6355 ("i2c: gpio: Convert to use descriptors") Cc: Wolfram Sang <[email protected]> Cc: Simon Guinot <[email protected]> Reported-by: Simon Guinot <[email protected]> Signed-off-by: Linus Walleij <[email protected]> Signed-off-by: Olof Johansson <[email protected]>
1 parent 0ec46ab commit f59c303

File tree

10 files changed

+11
-11
lines changed

10 files changed

+11
-11
lines changed

arch/arm/mach-ep93xx/core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ void __init ep93xx_register_eth(struct ep93xx_eth_data *data, int copy_addr)
323323

324324
/* All EP93xx devices use the same two GPIO pins for I2C bit-banging */
325325
static struct gpiod_lookup_table ep93xx_i2c_gpiod_table = {
326-
.dev_id = "i2c-gpio",
326+
.dev_id = "i2c-gpio.0",
327327
.table = {
328328
/* Use local offsets on gpiochip/port "G" */
329329
GPIO_LOOKUP_IDX("G", 1, NULL, 0,

arch/arm/mach-ixp4xx/avila-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ static struct platform_device avila_flash = {
5151
};
5252

5353
static struct gpiod_lookup_table avila_i2c_gpiod_table = {
54-
.dev_id = "i2c-gpio",
54+
.dev_id = "i2c-gpio.0",
5555
.table = {
5656
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", AVILA_SDA_PIN,
5757
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-ixp4xx/dsmg600-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ static struct platform_device dsmg600_flash = {
7070
};
7171

7272
static struct gpiod_lookup_table dsmg600_i2c_gpiod_table = {
73-
.dev_id = "i2c-gpio",
73+
.dev_id = "i2c-gpio.0",
7474
.table = {
7575
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", DSMG600_SDA_PIN,
7676
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-ixp4xx/fsg-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ static struct platform_device fsg_flash = {
5656
};
5757

5858
static struct gpiod_lookup_table fsg_i2c_gpiod_table = {
59-
.dev_id = "i2c-gpio",
59+
.dev_id = "i2c-gpio.0",
6060
.table = {
6161
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", FSG_SDA_PIN,
6262
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-ixp4xx/ixdp425-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ static struct platform_device ixdp425_flash_nand = {
124124
#endif /* CONFIG_MTD_NAND_PLATFORM */
125125

126126
static struct gpiod_lookup_table ixdp425_i2c_gpiod_table = {
127-
.dev_id = "i2c-gpio",
127+
.dev_id = "i2c-gpio.0",
128128
.table = {
129129
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", IXDP425_SDA_PIN,
130130
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-ixp4xx/nas100d-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ static struct platform_device nas100d_leds = {
102102
};
103103

104104
static struct gpiod_lookup_table nas100d_i2c_gpiod_table = {
105-
.dev_id = "i2c-gpio",
105+
.dev_id = "i2c-gpio.0",
106106
.table = {
107107
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", NAS100D_SDA_PIN,
108108
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-ixp4xx/nslu2-setup.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ static struct platform_device nslu2_flash = {
7070
};
7171

7272
static struct gpiod_lookup_table nslu2_i2c_gpiod_table = {
73-
.dev_id = "i2c-gpio",
73+
.dev_id = "i2c-gpio.0",
7474
.table = {
7575
GPIO_LOOKUP_IDX("IXP4XX_GPIO_CHIP", NSLU2_SDA_PIN,
7676
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-pxa/palmz72.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ static struct soc_camera_link palmz72_iclink = {
322322
};
323323

324324
static struct gpiod_lookup_table palmz72_i2c_gpiod_table = {
325-
.dev_id = "i2c-gpio",
325+
.dev_id = "i2c-gpio.0",
326326
.table = {
327327
GPIO_LOOKUP_IDX("gpio-pxa", 118, NULL, 0,
328328
GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-pxa/viper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ static struct platform_device smc91x_device = {
460460

461461
/* i2c */
462462
static struct gpiod_lookup_table viper_i2c_gpiod_table = {
463-
.dev_id = "i2c-gpio",
463+
.dev_id = "i2c-gpio.1",
464464
.table = {
465465
GPIO_LOOKUP_IDX("gpio-pxa", VIPER_RTC_I2C_SDA_GPIO,
466466
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),
@@ -789,7 +789,7 @@ static int __init viper_tpm_setup(char *str)
789789
__setup("tpm=", viper_tpm_setup);
790790

791791
struct gpiod_lookup_table viper_tpm_i2c_gpiod_table = {
792-
.dev_id = "i2c-gpio",
792+
.dev_id = "i2c-gpio.2",
793793
.table = {
794794
GPIO_LOOKUP_IDX("gpio-pxa", VIPER_TPM_I2C_SDA_GPIO,
795795
NULL, 0, GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

arch/arm/mach-sa1100/simpad.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ static struct platform_device simpad_gpio_leds = {
327327
* i2c
328328
*/
329329
static struct gpiod_lookup_table simpad_i2c_gpiod_table = {
330-
.dev_id = "i2c-gpio",
330+
.dev_id = "i2c-gpio.0",
331331
.table = {
332332
GPIO_LOOKUP_IDX("gpio", 21, NULL, 0,
333333
GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN),

0 commit comments

Comments
 (0)