Skip to content

Commit c9cc8d5

Browse files
authored
Merge pull request #261 from benfrankel/fix-dry-run
Avoid logging or returning from cache when `dry_run=True`
2 parents f57d7f5 + 4d9da96 commit c9cc8d5

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

doc/whatsnew.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Next release
1616
- Fix two regressions in :func:`.to_pandas` introduced in v2.23.0 (:issue:`251`, :pull:`252`).
1717
- Fix false cache hits and misses (thanks :gh-user:`benfrankel` for :issue:`256`, :pull:`257`).
1818
- Fix a bug where supplying `references=...` to ESTAT or EMPL would raise :class:`ValueError` (thanks :gh-user:`benfrankel` for :issue:`259`, :pull:`260`).
19+
- Adjust :meth:`.Client.get` to avoid logging or returning a message from cache when `dry_run=True` (thanks :gh-user:`benfrankel` for :pull:`261`).
1920

2021
v2.23.1 (2025-10-01)
2122
====================

sdmx/client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -456,6 +456,8 @@ def get(
456456
req = self._request_from_args(kwargs)
457457

458458
req_prepared = self.session.prepare_request(req)
459+
if dry_run:
460+
return req_prepared # type: ignore [return-value]
459461

460462
# Now get the SDMX message via HTTP
461463
log.info(f"Request {req_prepared.url}")
@@ -469,9 +471,6 @@ def get(
469471
log.info("Not found in cache")
470472
pass
471473

472-
if dry_run:
473-
return req_prepared # type: ignore [return-value]
474-
475474
try:
476475
# Send the request
477476
response = self.session.send(req_prepared, **self._send_kwargs)

0 commit comments

Comments
 (0)