v1.8.14-7 to remove analogRead() from example

### Releases v1.8.14-7

1. Modify [WiFiWebServer](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiWebServer) example to avoid `analogRead()` crash in `arduino-pico` core. Check [WiFi.localIP() hangs in Nano RP2040 Connect with Arduino-Pico core (EarlePhilhower) #24](#24)
2. Use `allman astyle` and add `utils`
3. Update `Packages' Patches`

Author: khoih-prog

CONTRIBUTING.md

@@ -15,7 +15,7 @@ If you don't find anything, please [open a new issue](https://github.com/khoih-p
 Please ensure to specify the following:
 
 * Arduino IDE version (e.g. 1.8.19) or Platform.io version
-* Core Version (e.g. Arduino SAMD core v1.8.13, Adafruit SAMD core v1.7.10, Arduino-mbed RP2040 v3.1.1)
+* Core Version (e.g. Arduino SAMD core v1.8.13, Adafruit SAMD core v1.7.11, Arduino-mbed RP2040 v3.4.1)
 * Board type (e.g. NANO_RP2040_CONNECT, RASPBERRY_PI_PICO, ADAFRUIT_FEATHER_RP2040, GENERIC_RP2040, etc.)
 * Contextual information (e.g. what you were trying to achieve)
 * Simplest possible steps to reproduce
@@ -28,29 +28,50 @@ Please ensure to specify the following:
 
 ```
 Arduino IDE version: 1.8.19
-Arduino-mbed RP2040 v3.1.1
+Arduino-mbed RP2040 v3.4.1
 NANO_RP2040_CONNECT Module
 OS: Ubuntu 20.04 LTS
-Linux xy-Inspiron-3593 5.15.0-41-generic #44~20.04.1-Ubuntu SMP Fri Jun 24 13:27:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
+Linux xy-Inspiron-3593 5.15.0-52-generic #58~20.04.1-Ubuntu SMP Thu Oct 13 13:09:46 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
 
 Context:
-I encountered an endless loop while trying to connect to Local WiFi.
-
+I encountered a crash while using this library
 Steps to reproduce:
 1. ...
 2. ...
 3. ...
 4. ...
 ```
 
+### Additional context
+
+Add any other context about the problem here.
+
+---
 
 ### Sending Feature Requests
 
 Feel free to post feature requests. It's helpful if you can explain exactly why the feature would be useful.
 
 There are usually some outstanding feature requests in the [existing issues list](https://github.com/khoih-prog/WiFiNINA_Generic/issues?q=is%3Aopen+is%3Aissue+label%3Aenhancement), feel free to add comments to them.
 
+---
+
 ### Sending Pull Requests
 
 Pull Requests with changes and fixes are also welcome!
 
+Please use the `astyle` to reformat the updated library code as follows (demo for Ubuntu Linux)
+
+1. Change directory to the library GitHub
+
+```
+xy@xy-Inspiron-3593:~$ cd Arduino/xy/WiFiNINA_Generic_GitHub/
+xy@xy-Inspiron-3593:~/Arduino/xy/WiFiNINA_Generic_GitHub$
+```
+
+2. Issue astyle command
+
+```
+xy@xy-Inspiron-3593:~/Arduino/xy/WiFiNINA_Generic_GitHub$ bash utils/restyle.sh
+```
+

README.md

@@ -6,12 +6,19 @@
 [![contributions welcome](https://img.shields.io/badge/contributions-welcome-brightgreen.svg?style=flat)](#Contributing)
 [![GitHub issues](https://img.shields.io/github/issues/khoih-prog/WiFiNINA_Generic.svg)](http://github.com/khoih-prog/WiFiNINA_Generic/issues)
 
+
+<a href="https://www.buymeacoffee.com/khoihprog6" title="Donate to my libraries using BuyMeACoffee"><img src="https://cdn.buymeacoffee.com/buttons/v2/default-yellow.png" alt="Donate to my libraries using BuyMeACoffee" style="height: 50px !important;width: 181px !important;" ></a>
+<a href="https://www.buymeacoffee.com/khoihprog6" title="Donate to my libraries using BuyMeACoffee"><img src="https://img.shields.io/badge/buy%20me%20a%20coffee-donate-orange.svg?logo=buy-me-a-coffee&logoColor=FFDD00" style="height: 20px !important;width: 200px !important;" ></a>
+<a href="https://profile-counter.glitch.me/khoih-prog/count.svg" title="Total khoih-prog Visitor count"><img src="https://profile-counter.glitch.me/khoih-prog/count.svg" style="height: 30px;width: 200px;"></a>
+<a href="https://profile-counter.glitch.me/khoih-prog-WiFiNINA_Generic/count.svg" title="WiFiNINA_Generic Visitor count"><img src="https://profile-counter.glitch.me/khoih-prog-WiFiNINA_Generic/count.svg" style="height: 30px;width: 200px;"></a>
+
 ---
 ---
 
 ## Table of Contents
 
 * [Changelog](#changelog)
+  * [Releases v1.8.14-7](#releases-v1814-7)
   * [Releases v1.8.14-6](#releases-v1814-6)
   * [Releases v1.8.14-5](#releases-v1814-5)
   * [Releases v1.8.14-4](#releases-v1814-4)
@@ -42,6 +49,12 @@
 
 ## Changelog
 
+### Releases v1.8.14-7
+
+1. Modify [WiFiWebServer](https://github.com/khoih-prog/WiFiNINA_Generic/tree/master/examples/WiFiWebServer) example to avoid `analogRead()` crash in `arduino-pico` core. Check [WiFi.localIP() hangs in Nano RP2040 Connect with Arduino-Pico core (EarlePhilhower) #24](https://github.com/khoih-prog/WiFiNINA_Generic/discussions/24)
+2. Use `allman astyle` and add `utils`
+3. Update `Packages' Patches`
+
 ### Releases v1.8.14-6
 
 1. Add support to `Teensy 4.x` using `Adafruit Airlift Featherwing Co-Processor`

changelog.md

@@ -1,6 +1,6 @@
 {
   "name": "WiFiNINA_Generic",
-  "version": "1.8.14-6",
+  "version": "1.8.14-7",
   "keywords": "wifi, wi-fi, WiFiNINA, NINA-B302-ublox, W101, W102, shield, Teensy, SAM DUE, SAMD, STM32, nRF52, rpi-pico, rp2040, Credentials, Manager, nano-rp2040-connect, raspberry-pi-pico, mega, 32u4",
   "description": "Enables network connection (local and Internet) and WiFiStorage for SAM DUE, SAMD21, SAMD51, Teensy, AVR (328P, 32u4, 16u4, etc.), Mega, STM32F/L/H/G/WB/MP1, nRF52, NINA_B302_ublox, NINA_B112_ublox, RP2040-based boards, etc. in addition to Arduino MKR WiFi 1010, Arduino MKR VIDOR 4000, Arduino UNO WiFi Rev.2, Nano 33 IoT, Nano RP2040 Connect",
   "authors": [
@@ -34,12 +34,12 @@
     {
       "owner": "khoih-prog",
       "name": "WiFiMulti_Generic",
-      "version": ">=1.1.1",
+      "version": ">=1.2.2",
       "platforms": ["*"]
     }
   ],
   "frameworks": "*",
   "platforms": "*",
   "examples": "examples/*/*/*.ino",
-  "headers": "WiFiNINA_Generic.h"
+  "headers": ["WiFiNINA_Generic.h"]
 }

library.json

@@ -1,5 +1,5 @@
 name=WiFiNINA_Generic
-version=1.8.14-6
+version=1.8.14-7
 author=Arduino, Khoi Hoang <[email protected]>
 maintainer=Khoi Hoang <[email protected]>
 sentence=Enables network connection (local and Internet) and WiFiStorage for SAM DUE, SAMD21, SAMD51, Teensy, AVR (328P, 32u4, 16u4, etc.), Mega, STM32F/L/H/G/WB/MP1, nRF52, NINA_B302_ublox, NINA_B112_ublox, RP2040-based boards, etc. in addition to Arduino MKR WiFi 1010, Arduino MKR VIDOR 4000, Arduino UNO WiFi Rev.2, Nano 33 IoT, Nano RP2040 Connect

library.properties

@@ -3,7 +3,7 @@
 
   Based on and modified from WiFiNINA library https://www.arduino.cc/en/Reference/WiFiNINA
   to support nRF52, SAMD21/SAMD51, STM32F/L/H/G/WB/MP1, Teensy, etc. boards besides Nano-33 IoT, MKRWIFI1010, MKRVIDOR400, etc.
-  
+
   Built by Khoi Hoang https://github.com/khoih-prog/WiFiNINA_Generic
   Licensed under MIT license
 
@@ -23,8 +23,8 @@
   You should have received a copy of the GNU Lesser General Public
   License along with this library; if not, write to the Free Software
   Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
-  
-  Version: 1.8.14-6
+
+  Version: 1.8.14-7
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -38,16 +38,17 @@
   1.8.14-4   K Hoang    01/05/2022 Fix bugs by using some PRs from original WiFiNINA. Add WiFiMulti-related examples
   1.8.14-5   K Hoang    23/05/2022 Fix bug causing data lost when sending large files
   1.8.14-6   K Hoang    17/08/2022 Add support to Teensy 4.x using WiFiNINA AirLift. Fix minor bug
+  1.8.14-7   K Hoang    11/11/2022 Modify WiFiWebServer example to avoid crash in arduino-pico core
  ***********************************************************************************************************************************/
 
 #define _WIFININA_LOGLEVEL_         1
 
-extern "C" 
+extern "C"
 {
-  #include "utility/wl_definitions.h"
-  #include "utility/wl_types.h"
-  #include "string.h"
-  #include "utility/debug.h"
+#include "utility/wl_definitions.h"
+#include "utility/wl_types.h"
+#include "string.h"
+#include "utility/debug.h"
 }
 
 
@@ -111,7 +112,7 @@ int WiFiClient::connect(IPAddress ip, uint16_t port)
   {
     // KH
     NN_LOGDEBUG(F("No Socket available"));
-    
+
     return 0;
   }
 
@@ -152,6 +153,7 @@ int WiFiClient::connectSSL(IPAddress ip, uint16_t port)
 
     return 0;
   }
+
   return 1;
 }
 
@@ -163,7 +165,7 @@ int WiFiClient::connectSSL(const char *host, uint16_t port)
   }
 
   _sock = ServerDrv::getSocket();
-  
+
   if (_sock != NO_SOCKET_AVAIL)
   {
     ServerDrv::startClient(host, strlen(host), uint32_t(0), port, _sock, TLS_MODE);
@@ -220,15 +222,15 @@ int WiFiClient::connectBearSSL(IPAddress ip, uint16_t port)
     {
       return 0;
     }
-  } 
-  else 
+  }
+  else
   {
     // KH
     NN_LOGDEBUG(F("No Socket available"));
-    
+
     return 0;
   }
-  
+
   return 1;
 }
 
@@ -240,7 +242,7 @@ int WiFiClient::connectBearSSL(const char *host, uint16_t port)
   }
 
   _sock = ServerDrv::getSocket();
-  
+
   if (_sock != NO_SOCKET_AVAIL)
   {
     ServerDrv::startClient(host, strlen(host), uint32_t(0), port, _sock, TLS_BEARSSL_MODE);
@@ -258,15 +260,15 @@ int WiFiClient::connectBearSSL(const char *host, uint16_t port)
     {
       return 0;
     }
-  } 
-  else 
+  }
+  else
   {
     // KH
     NN_LOGDEBUG(F("No Socket available"));
-    
+
     return 0;
   }
-  
+
   return 1;
 }
 //////
@@ -281,68 +283,68 @@ size_t WiFiClient::write(uint8_t b)
 size_t WiFiClient::write(const uint8_t *buf, size_t size)
 {
   NN_LOGDEBUG1("WiFiClient::write: To write, size = ", size);
-  
+
   if (_sock == NO_SOCKET_AVAIL)
   {
     setWriteError();
-    
+
     NN_LOGDEBUG("WiFiClient::write: NO_SOCKET_AVAIL");
-    
+
     return 0;
   }
 
   if (size == 0)
   {
     setWriteError();
-    
+
     NN_LOGDEBUG("WiFiClient::write: size = 0");
-    
+
     return 0;
   }
 
   size_t written = ServerDrv::sendData(_sock, buf, size);
-  
+
   uint8_t timesResent = 0;
-  
+
   while ( (written != size) && (timesResent++ < 100) )
   {
     // Don't use too short delay so that NINA has some time to recover
     // The fix is considered as kludge, and the correct place to fix is in ServerDrv::sendData()
     delay(100);
-    
+
     written += ServerDrv::sendData(_sock, buf + written, size - written);
   }
-  
+
   NN_LOGDEBUG1("WiFiClient::write: loopSend => written = ", written);
   NN_LOGDEBUG1("WiFiClient::write: loopSend => timesResent = ", timesResent);
-  
-  if (!written && _retrySend) 
+
+  if (!written && _retrySend)
   {
     written = retry(buf, size, true);
-    
+
     NN_LOGDEBUG1("WiFiClient::write: _retrySend => written = ", written);
   }
-  
+
   if (!written)
   {
     // close socket
     ServerDrv::stopClient(_sock);
     setWriteError();
-    
+
     NN_LOGDEBUG("WiFiClient::write: !written error");
-    
+
     return 0;
   }
 
   if (!ServerDrv::checkDataSent(_sock))
   {
     setWriteError();
-    
+
     NN_LOGDEBUG("WiFiClient::write: error !checkDataSent");
-    
+
     return 0;
   }
-  
+
   if (written == size)
   {
     NN_LOGINFO1("WiFiClient::write: OK, written = ", written);
@@ -357,26 +359,26 @@ size_t WiFiClient::write(const uint8_t *buf, size_t size)
 
 ///////////////////////////////////////////////////////////////////////////
 
-size_t WiFiClient::retry(const uint8_t *buf, size_t size, bool write) 
+size_t WiFiClient::retry(const uint8_t *buf, size_t size, bool write)
 {
   size_t rec_bytes = 0;
 
-  if (write) 
+  if (write)
   {
     //RETRY WRITE
-    for (int i = 0; i < 5; i++) 
+    for (int i = 0; i < 5; i++)
     {
       rec_bytes = ServerDrv::sendData(_sock, buf, size);
-      
-      if (rec_bytes) 
+
+      if (rec_bytes)
       {
         break;
       }
     }
-    
+
     return rec_bytes;
   }
-  else 
+  else
   {
     //RETRY READ
     // To be implemented, if needed
@@ -418,7 +420,7 @@ int WiFiClient::peek()
   return WiFiSocketBuffer.peek(_sock);
 }
 
-void WiFiClient::setRetry(bool retry) 
+void WiFiClient::setRetry(bool retry)
 {
   _retrySend = retry;
 }