Merge pull request #44 from khornberg/bug/jwt-expiration

khornberg · web-flow · commit 837b39b20dce · 2019-01-02T13:33:44.000-06:00
Bug Fix: Reduce expiration date
diff --git a/setup.py b/setup.py
@@ -21,7 +21,7 @@ def read(*names, **kwargs):
 
 setup(
     name='octokitpy',
-    version='0.9.1',
+    version='0.9.2',
     license='MIT license',
     description='Python client for GitHub API',
     long_description='%s\n%s' % (
diff --git a/src/octokit/__init__.py b/src/octokit/__init__.py
@@ -134,7 +134,7 @@ def _app_auth_get_token(self, app_id, key):
     def _app_auth_get_jwt(self, app_id, key):
         payload = {
             'iat': int(datetime.datetime.timestamp(datetime.datetime.now())),
-            'exp': int(datetime.datetime.timestamp(datetime.datetime.now())) + (10 * 60),
+            'exp': int(datetime.datetime.timestamp(datetime.datetime.now())) + (9 * 60),
             'iss': app_id,
         }
         return jwt.encode(payload, key, algorithm='RS256')

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ def _app_auth_get_token(self, app_id, key):`
`134`	`134`	`def _app_auth_get_jwt(self, app_id, key):`
`135`	`135`	`payload = {`
`136`	`136`	`'iat': int(datetime.datetime.timestamp(datetime.datetime.now())),`
`137`		`- 'exp': int(datetime.datetime.timestamp(datetime.datetime.now())) + (10 * 60),`
	`137`	`+ 'exp': int(datetime.datetime.timestamp(datetime.datetime.now())) + (9 * 60),`
`138`	`138`	`'iss': app_id,`
`139`	`139`	`}`
`140`	`140`	`return jwt.encode(payload, key, algorithm='RS256')`