Skip to content

Commit 034ebe0

Browse files
Akhil Rgregkh
authored andcommitted
dt-bindings: i2c: nvidia,tegra20-i2c: Specify the required properties
commit 903cc7096db22f889d48e2cee8840709ce04fdac upstream. Specify the properties which are essential and which are not for the Tegra I2C driver to function correctly. This was not added correctly when the TXT binding was converted to yaml. All the existing DT nodes have these properties already and hence this does not break the ABI. dmas and dma-names which were specified as a must in the TXT binding is now made optional since the driver can work in PIO mode if dmas are missing. Fixes: f10a9b7 ("dt-bindings: i2c: tegra: Convert to json-schema”) Signed-off-by: Akhil R <[email protected]> Cc: <[email protected]> # v5.17+ Reviewed-by: Krzysztof Kozlowski <[email protected]> Signed-off-by: Andi Shyti <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e612c4b commit 034ebe0

File tree

1 file changed

+23
-1
lines changed

1 file changed

+23
-1
lines changed

Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,10 @@ properties:
103103

104104
resets:
105105
items:
106-
- description: module reset
106+
- description:
107+
Module reset. This property is optional for controllers in Tegra194,
108+
Tegra234 etc where an internal software reset is available as an
109+
alternative.
107110

108111
reset-names:
109112
items:
@@ -119,6 +122,13 @@ properties:
119122
- const: rx
120123
- const: tx
121124

125+
required:
126+
- compatible
127+
- reg
128+
- interrupts
129+
- clocks
130+
- clock-names
131+
122132
allOf:
123133
- $ref: /schemas/i2c/i2c-controller.yaml
124134
- if:
@@ -172,6 +182,18 @@ allOf:
172182
items:
173183
- description: phandle to the VENC power domain
174184

185+
- if:
186+
not:
187+
properties:
188+
compatible:
189+
contains:
190+
enum:
191+
- nvidia,tegra194-i2c
192+
then:
193+
required:
194+
- resets
195+
- reset-names
196+
175197
unevaluatedProperties: false
176198

177199
examples:

0 commit comments

Comments
 (0)