Skip to content

Commit 1a1b2b8

Browse files
Jiri Kosinagregkh
authored andcommitted
Revert "HID: multitouch: Add support for lenovo Y9000P Touchpad"
commit 3d88ba86ba6f35a0467f25a88c38aa5639190d04 upstream. This reverts commit 251efae73bd46b097deec4f9986d926813aed744. Quoting Wang Yuli: "The 27C6:01E0 touchpad doesn't require the workaround and applying it would actually break functionality. The initial report came from a BBS forum, but we suspect the information provided by the forum user may be incorrect which could happen sometimes. [1] Further investigation showed that the Lenovo Y9000P 2024 doesn't even use a Goodix touchpad. [2] For the broader issue of 27c6:01e0 being unusable on some devices, it just need to address it with a libinput quirk. In conclusion, we should revert this commit, which is the best solution." Reported-by: Ulrich Müller <[email protected]> Reported-by: WangYuli <[email protected]> Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Jiri Kosina <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8476f84 commit 1a1b2b8

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

drivers/hid/hid-ids.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -507,7 +507,6 @@
507507
#define USB_DEVICE_ID_GENERAL_TOUCH_WIN8_PIT_E100 0xe100
508508

509509
#define I2C_VENDOR_ID_GOODIX 0x27c6
510-
#define I2C_DEVICE_ID_GOODIX_01E0 0x01e0
511510
#define I2C_DEVICE_ID_GOODIX_01E8 0x01e8
512511
#define I2C_DEVICE_ID_GOODIX_01E9 0x01e9
513512
#define I2C_DEVICE_ID_GOODIX_01F0 0x01f0

drivers/hid/hid-multitouch.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,8 +1447,7 @@ static __u8 *mt_report_fixup(struct hid_device *hdev, __u8 *rdesc,
14471447
{
14481448
if (hdev->vendor == I2C_VENDOR_ID_GOODIX &&
14491449
(hdev->product == I2C_DEVICE_ID_GOODIX_01E8 ||
1450-
hdev->product == I2C_DEVICE_ID_GOODIX_01E9 ||
1451-
hdev->product == I2C_DEVICE_ID_GOODIX_01E0)) {
1450+
hdev->product == I2C_DEVICE_ID_GOODIX_01E9)) {
14521451
if (rdesc[607] == 0x15) {
14531452
rdesc[607] = 0x25;
14541453
dev_info(
@@ -2073,10 +2072,7 @@ static const struct hid_device_id mt_devices[] = {
20732072
I2C_DEVICE_ID_GOODIX_01E8) },
20742073
{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
20752074
HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX,
2076-
I2C_DEVICE_ID_GOODIX_01E9) },
2077-
{ .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT_NSMU,
2078-
HID_DEVICE(BUS_I2C, HID_GROUP_ANY, I2C_VENDOR_ID_GOODIX,
2079-
I2C_DEVICE_ID_GOODIX_01E0) },
2075+
I2C_DEVICE_ID_GOODIX_01E8) },
20802076

20812077
/* GoodTouch panels */
20822078
{ .driver_data = MT_CLS_NSMU,

0 commit comments

Comments
 (0)