Skip to content

Commit 50472dc

Browse files
kuu-rtgregkh
authored andcommitted
platform/x86: think-lmi: Fix class device unregistration
[ Upstream commit 5ff1fbb3059730700b4823f43999fc1315984632 ] Devices under the firmware_attributes_class do not have unique a dev_t. Therefore, device_unregister() should be used instead of device_destroy(), since the latter may match any device with a given dev_t. Fixes: a40cd7e ("platform/x86: think-lmi: Add WMI interface support on Lenovo platforms") Signed-off-by: Kurt Borja <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Ilpo Järvinen <[email protected]> Signed-off-by: Ilpo Järvinen <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent fadd5d8 commit 50472dc

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/platform/x86/think-lmi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,7 +1380,7 @@ static int tlmi_sysfs_init(void)
13801380
fail_create_attr:
13811381
tlmi_release_attr();
13821382
fail_device_created:
1383-
device_destroy(fw_attr_class, MKDEV(0, 0));
1383+
device_unregister(tlmi_priv.class_dev);
13841384
fail_class_created:
13851385
fw_attributes_class_put();
13861386
return ret;
@@ -1602,7 +1602,7 @@ static int tlmi_analyze(void)
16021602
static void tlmi_remove(struct wmi_device *wdev)
16031603
{
16041604
tlmi_release_attr();
1605-
device_destroy(fw_attr_class, MKDEV(0, 0));
1605+
device_unregister(tlmi_priv.class_dev);
16061606
fw_attributes_class_put();
16071607
}
16081608

0 commit comments

Comments
 (0)