Skip to content

Commit 68ac5a0

Browse files
axiqiagregkh
authored andcommitted
dmaengine: idxd: Add missing idxd cleanup to fix memory leak in remove call
commit d5449ff1b04dfe9ed8e455769aa01e4c2ccf6805 upstream. The remove call stack is missing idxd cleanup to free bitmap, ida and the idxd_device. Call idxd_free() helper routines to make sure we exit gracefully. Fixes: bfe1d56 ("dmaengine: idxd: Init and probe for Intel data accelerators") Cc: [email protected] Suggested-by: Vinicius Costa Gomes <[email protected]> Signed-off-by: Shuai Xue <[email protected]> Reviewed-by: Fenghua Yu <[email protected]> Reviewed-by: Dave Jiang <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 24d9c14 commit 68ac5a0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/dma/idxd/init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -796,6 +796,7 @@ static void idxd_remove(struct pci_dev *pdev)
796796
destroy_workqueue(idxd->wq);
797797
perfmon_pmu_remove(idxd);
798798
put_device(idxd_confdev(idxd));
799+
idxd_free(idxd);
799800
}
800801

801802
static struct pci_driver idxd_pci_driver = {

0 commit comments

Comments
 (0)