pmdomain: core: Add missing put_device()

storulf · gregkh · commit da719022a474 · 2025-01-02T10:30:54.000+01:00
[ Upstream commit b8f7bbd1f4ecff6d6277b8c454f62bb0a1c6dbe4 ] When removing a genpd we don't clean up the genpd->dev correctly. Let's add the missing put_device() in genpd_free_data() to fix this. Fixes: 401ea15 ("PM / Domain: Add struct device to genpd") Cc: stable@vger.kernel.org Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> Message-ID: <20241122134207.157283-2-ulf.hansson@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
@@ -2012,6 +2012,7 @@ static int genpd_alloc_data(struct generic_pm_domain *genpd)
 
 static void genpd_free_data(struct generic_pm_domain *genpd)
 {
+	put_device(&genpd->dev);
 	if (genpd_is_cpu_domain(genpd))
 		free_cpumask_var(genpd->cpus);
 	if (genpd->free_states)

Original file line number	Diff line number	Diff line change
`@@ -2012,6 +2012,7 @@ static int genpd_alloc_data(struct generic_pm_domain *genpd)`
`2012`	`2012`
`2013`	`2013`	`static void genpd_free_data(struct generic_pm_domain *genpd)`
`2014`	`2014`	`{`
	`2015`	`+ put_device(&genpd->dev);`
`2015`	`2016`	`if (genpd_is_cpu_domain(genpd))`
`2016`	`2017`	`free_cpumask_var(genpd->cpus);`
`2017`	`2018`	`if (genpd->free_states)`