Skip to content

Commit f19009e

Browse files
Kaustabh Chakrabortygregkh
authored andcommitted
phy: exynos5-usbdrd: fix MPLL_MULTIPLIER and SSC_REFCLKSEL masks in refclk
commit e2158c953c973adb49383ddea2504faf08d375b7 upstream. In exynos5_usbdrd_{pipe3,utmi}_set_refclk(), the masks PHYCLKRST_MPLL_MULTIPLIER_MASK and PHYCLKRST_SSC_REFCLKSEL_MASK are not inverted when applied to the register values. Fix it. Cc: [email protected] Fixes: 5902588 ("phy: Add new Exynos5 USB 3.0 PHY driver") Signed-off-by: Kaustabh Chakraborty <[email protected]> Reviewed-by: Krzysztof Kozlowski <[email protected]> Reviewed-by: Anand Moon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Vinod Koul <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 14d1a86 commit f19009e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/phy/samsung/phy-exynos5-usbdrd.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -288,9 +288,9 @@ exynos5_usbdrd_pipe3_set_refclk(struct phy_usb_instance *inst)
288288
reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
289289

290290
/* FSEL settings corresponding to reference clock */
291-
reg &= ~PHYCLKRST_FSEL_PIPE_MASK |
292-
PHYCLKRST_MPLL_MULTIPLIER_MASK |
293-
PHYCLKRST_SSC_REFCLKSEL_MASK;
291+
reg &= ~(PHYCLKRST_FSEL_PIPE_MASK |
292+
PHYCLKRST_MPLL_MULTIPLIER_MASK |
293+
PHYCLKRST_SSC_REFCLKSEL_MASK);
294294
switch (phy_drd->extrefclk) {
295295
case EXYNOS5_FSEL_50MHZ:
296296
reg |= (PHYCLKRST_MPLL_MULTIPLIER_50M_REF |
@@ -332,9 +332,9 @@ exynos5_usbdrd_utmi_set_refclk(struct phy_usb_instance *inst)
332332
reg &= ~PHYCLKRST_REFCLKSEL_MASK;
333333
reg |= PHYCLKRST_REFCLKSEL_EXT_REFCLK;
334334

335-
reg &= ~PHYCLKRST_FSEL_UTMI_MASK |
336-
PHYCLKRST_MPLL_MULTIPLIER_MASK |
337-
PHYCLKRST_SSC_REFCLKSEL_MASK;
335+
reg &= ~(PHYCLKRST_FSEL_UTMI_MASK |
336+
PHYCLKRST_MPLL_MULTIPLIER_MASK |
337+
PHYCLKRST_SSC_REFCLKSEL_MASK);
338338
reg |= PHYCLKRST_FSEL(phy_drd->extrefclk);
339339

340340
return reg;

0 commit comments

Comments
 (0)