Correct a few more memory leaks in Setup flows

Author: kiall

app/build.gradle

@@ -68,7 +68,7 @@ repositories {
 }
 
 dependencies {
-    compile 'ie.macinnes.htsp:android-htsp:v0.0.1a14'
+    compile 'ie.macinnes.htsp:android-htsp:v0.0.1a15'
     // Used for testing local HTSP lib builds
 //    compile(name: 'library-debug', ext: 'aar')
     compile fileTree(include: ['*.jar'], dir: 'libs')

app/src/main/java/ie/macinnes/tvheadend/account/AuthenticatorActivity.java

@@ -368,6 +368,9 @@ public void onStop() {
             super.onStop();
 
             mConnection.stop();
+            mConnection.removeConnectionListener(this);
+            mConnection.removeAuthenticationListener(this);
+            mConnection = null;
         }
 
         @Override

app/src/main/java/ie/macinnes/tvheadend/setup/TvInputSetupActivity.java

@@ -318,6 +318,13 @@ public void onStart() {
         @Override
         public void onStop() {
             mConnection.stop();
+            mConnection.removeMessageListener(mEpgSyncTask);
+            mConnection.removeAuthenticationListener(mEpgSyncTask);
+            mConnection = null;
+
+            mEpgSyncTask.removeEpgSyncListener(this);
+            mEpgSyncTask = null;
+
             super.onStop();
         }
 

app/src/main/java/ie/macinnes/tvheadend/sync/EpgSyncTask.java

@@ -639,8 +639,8 @@ protected void deletePrograms() {
     }
 
     private void handleInitialSyncCompleted(@NonNull HtspMessage message) {
-        // Ensure we wrap up any pending channel operations before moving onto events. This is no-op
-        // once there are no pending operations
+        // Ensure we wrap up any pending channel operations. This is no-op once there are no pending
+        // operations. This should only be needed when there were no events provided at all.
         flushPendingChannelOps();
 
         // Ensure we wrap up any pending event operations. This is no-op once there are no pending