Skip to content

Commit 9eeed2d

Browse files
committed
Simplify TvheadendRenderersFactory
1 parent b77df3a commit 9eeed2d

File tree

2 files changed

+7
-23
lines changed

2 files changed

+7
-23
lines changed

app/src/main/java/ie/macinnes/tvheadend/player/Player.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ public interface Listener {
102102
private final SharedPreferences mSharedPreferences;
103103

104104
private SimpleExoPlayer mExoPlayer;
105+
private RenderersFactory mRenderersFactory;
105106
private TvheadendTrackSelector mTrackSelector;
107+
private LoadControl mLoadControl;
106108
private EventLogger mEventLogger;
107109
private DataSource.Factory mDataSourceFactory;
108110
private ExtractorsFactory mExtractorsFactory;
@@ -200,14 +202,11 @@ private void buildExoPlayer() {
200202
TrackSelection.Factory trackSelectionFactory =
201203
new AdaptiveTrackSelection.Factory(null);
202204

205+
mRenderersFactory = new TvheadendRenderersFactory(mContext);
203206
mTrackSelector = new TvheadendTrackSelector(trackSelectionFactory);
207+
mLoadControl = buildLoadControl();
204208

205-
LoadControl loadControl = buildLoadControl();
206-
207-
RenderersFactory renderersFactory = new TvheadendRenderersFactory(
208-
mContext, null, TvheadendRenderersFactory.DEFAULT_ALLOWED_VIDEO_JOINING_TIME_MS);
209-
210-
mExoPlayer = ExoPlayerFactory.newSimpleInstance(renderersFactory, mTrackSelector, loadControl);
209+
mExoPlayer = ExoPlayerFactory.newSimpleInstance(mRenderersFactory, mTrackSelector, mLoadControl);
211210
mExoPlayer.addListener(this);
212211

213212
// Add the EventLogger

app/src/main/java/ie/macinnes/tvheadend/player/TvheadendRenderersFactory.java

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,10 @@
2020
import android.content.SharedPreferences;
2121
import android.os.Build;
2222
import android.os.Handler;
23-
import android.os.Looper;
2423
import android.util.Log;
2524

2625
import com.google.android.exoplayer2.DefaultRenderersFactory;
2726
import com.google.android.exoplayer2.Renderer;
28-
import com.google.android.exoplayer2.RenderersFactory;
29-
import com.google.android.exoplayer2.SimpleExoPlayer;
3027
import com.google.android.exoplayer2.audio.AudioCapabilities;
3128
import com.google.android.exoplayer2.audio.AudioProcessor;
3229
import com.google.android.exoplayer2.audio.AudioRendererEventListener;
@@ -37,8 +34,6 @@
3734
import com.google.android.exoplayer2.mediacodec.MediaCodecInfo;
3835
import com.google.android.exoplayer2.mediacodec.MediaCodecSelector;
3936
import com.google.android.exoplayer2.mediacodec.MediaCodecUtil;
40-
import com.google.android.exoplayer2.metadata.MetadataRenderer;
41-
import com.google.android.exoplayer2.text.TextRenderer;
4237
import com.google.android.exoplayer2.video.MediaCodecVideoRenderer;
4338
import com.google.android.exoplayer2.video.VideoRendererEventListener;
4439

@@ -50,18 +45,8 @@
5045
public class TvheadendRenderersFactory extends DefaultRenderersFactory {
5146
private static final String TAG = TvheadendRenderersFactory.class.getName();
5247

53-
private final Context mContext;
54-
private final DrmSessionManager<FrameworkMediaCrypto> mDrmSessionManager;
55-
private final long mAllowedVideoJoiningTimeMs;
56-
57-
public TvheadendRenderersFactory(Context context,
58-
DrmSessionManager<FrameworkMediaCrypto> drmSessionManager,
59-
long allowedVideoJoiningTimeMs) {
60-
super(context, drmSessionManager, EXTENSION_RENDERER_MODE_ON, allowedVideoJoiningTimeMs);
61-
62-
mContext = context;
63-
mDrmSessionManager = drmSessionManager;
64-
mAllowedVideoJoiningTimeMs = allowedVideoJoiningTimeMs;
48+
public TvheadendRenderersFactory(Context context) {
49+
super(context, null, EXTENSION_RENDERER_MODE_ON, DEFAULT_ALLOWED_VIDEO_JOINING_TIME_MS);
6550
}
6651

6752
/**

0 commit comments

Comments
 (0)