Skip to content

Commit 41f753f

Browse files
[8.x] [Obs AI Assistant] Fix page height of the AI Assistant app in solution views (elastic#215646) (elastic#215678)
# Backport This will backport the following commits from `main` to `8.x`: - [[Obs AI Assistant] Fix page height of the AI Assistant app in solution views (elastic#215646)](elastic#215646) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Viduni Wickramarachchi","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-03-24T12:16:46Z","message":"[Obs AI Assistant] Fix page height of the AI Assistant app in solution views (elastic#215646)\n\nCloses https://github.com/elastic/kibana/issues/215637\n\n## Summary\n\nIn solution views the AI Assistant page doesn't take up the full\nviewport height because a hardcoded value is used.\nThis PR fixes this issue by using `kbn/eui` variables instead.\n\nBefore:\n\n<img width=\"1619\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5c94c325-1a15-49da-b162-beb15431a732\"\n/>\n\nAfter:\n\n<img width=\"1621\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/88e0610e-cbfb-4266-a0fa-c19f031bbb93\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"505405df5c49e2166883a27baed948f2868b9e1a","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Obs AI Assistant","backport:version","v9.1.0","v8.19.0"],"title":"[Obs AI Assistant] Fix page height of the AI Assistant app in solution views","number":215646,"url":"https://github.com/elastic/kibana/pull/215646","mergeCommit":{"message":"[Obs AI Assistant] Fix page height of the AI Assistant app in solution views (elastic#215646)\n\nCloses https://github.com/elastic/kibana/issues/215637\n\n## Summary\n\nIn solution views the AI Assistant page doesn't take up the full\nviewport height because a hardcoded value is used.\nThis PR fixes this issue by using `kbn/eui` variables instead.\n\nBefore:\n\n<img width=\"1619\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5c94c325-1a15-49da-b162-beb15431a732\"\n/>\n\nAfter:\n\n<img width=\"1621\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/88e0610e-cbfb-4266-a0fa-c19f031bbb93\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"505405df5c49e2166883a27baed948f2868b9e1a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/215646","number":215646,"mergeCommit":{"message":"[Obs AI Assistant] Fix page height of the AI Assistant app in solution views (elastic#215646)\n\nCloses https://github.com/elastic/kibana/issues/215637\n\n## Summary\n\nIn solution views the AI Assistant page doesn't take up the full\nviewport height because a hardcoded value is used.\nThis PR fixes this issue by using `kbn/eui` variables instead.\n\nBefore:\n\n<img width=\"1619\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/5c94c325-1a15-49da-b162-beb15431a732\"\n/>\n\nAfter:\n\n<img width=\"1621\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/88e0610e-cbfb-4266-a0fa-c19f031bbb93\"\n/>\n\n\n### Checklist\n\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"505405df5c49e2166883a27baed948f2868b9e1a"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Viduni Wickramarachchi <[email protected]>
1 parent 9494ee8 commit 41f753f

File tree

1 file changed

+1
-1
lines changed
  • x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/components

1 file changed

+1
-1
lines changed

x-pack/solutions/observability/plugins/observability_ai_assistant_app/public/components/page_template.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const pageSectionContentClassName = css`
1414
flex-grow: 1;
1515
padding-top: 0;
1616
padding-bottom: 0;
17-
max-block-size: calc(100vh - 96px);
17+
max-block-size: calc(100vh - var(--kbnAppHeadersOffset, var(--euiFixedHeadersOffset, 0)));
1818
`;
1919

2020
export function ObservabilityAIAssistantPageTemplate({ children }: { children: React.ReactNode }) {

0 commit comments

Comments
 (0)