Commit a6a668b
authored
[9.2] [SharedUX] Add kbn-tour-queue package to avoid tour overlapping (elastic#242640) (elastic#243754)
# Backport
This will backport the following commits from `main` to `9.2`:
- [[SharedUX] Add kbn-tour-queue package to avoid tour overlapping
(elastic#242640)](elastic#242640)
<!--- Backport version: 10.2.0 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)
<!--BACKPORT [{"author":{"name":"Ángeles Martínez
Barrio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-11-20T16:30:43Z","message":"[SharedUX]
Add kbn-tour-queue package to avoid tour overlapping (elastic#242640)\n\nCloses
https://github.com/elastic/kibana-team/issues/2146\n\n## Summary\n\n-
This PR introduces a new package to orchestrate tours to
avoid\noverlapping. Currently, Side Nav Tour and Security tour are
overlapping\nin this way:\n\n<img width=\"675\" height=\"391\"
alt=\"Screenshot 2025-11-12 at 10 32
34\"\nsrc=\"https://github.com/user-attachments/assets/27a3ba52-2c69-4fe0-bf62-18d649354de5\"\n/>\n\n-
Package `kbn-tour-queue` uses `globalThis` to share state
across\nplugins and to ensure only one single instance of the state
manager is\nused. This approach is based on @Dosant
`kbn-developer-toolbar`
[state\nimplementation](https://github.com/elastic/kibana/blob/7518eebd9acaf352f02241901cbeb7129e0a1f32/src/platform/packages/shared/kbn-developer-toolbar/src/hooks/use_toolbar_state.tsx#L14-L40).\n-
If any of the tours in the queue are skipped, the remaining tours
are\nalso skipped (currently only Side Nav tour handles skip
behaviour).\nSkipped status is not persisted for now, it is only honored
until page\nreload.\n- Side Nav and Security tours were updated to use
the new tour queue\nsystem.\n\n### Testing\n\nTour completion (Spaces +
SideNav +
Security):\n\n\nhttps://github.com/user-attachments/assets/139847ac-48ea-41e6-8eba-cf5c4981ed96\n\nTour
skipping (Spaces +
SideNav):\n\n\nhttps://github.com/user-attachments/assets/e75f7aa0-6cb4-4c43-9117-172f88f1fe8b","sha":"60952a0bbdeb09c931eaf4469c01f21931836651","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:SharedUX","backport:version","v9.3.0","v9.2.2"],"title":"[SharedUX]
Add kbn-tour-queue package to avoid tour
overlapping","number":242640,"url":"https://github.com/elastic/kibana/pull/242640","mergeCommit":{"message":"[SharedUX]
Add kbn-tour-queue package to avoid tour overlapping (elastic#242640)\n\nCloses
https://github.com/elastic/kibana-team/issues/2146\n\n## Summary\n\n-
This PR introduces a new package to orchestrate tours to
avoid\noverlapping. Currently, Side Nav Tour and Security tour are
overlapping\nin this way:\n\n<img width=\"675\" height=\"391\"
alt=\"Screenshot 2025-11-12 at 10 32
34\"\nsrc=\"https://github.com/user-attachments/assets/27a3ba52-2c69-4fe0-bf62-18d649354de5\"\n/>\n\n-
Package `kbn-tour-queue` uses `globalThis` to share state
across\nplugins and to ensure only one single instance of the state
manager is\nused. This approach is based on @Dosant
`kbn-developer-toolbar`
[state\nimplementation](https://github.com/elastic/kibana/blob/7518eebd9acaf352f02241901cbeb7129e0a1f32/src/platform/packages/shared/kbn-developer-toolbar/src/hooks/use_toolbar_state.tsx#L14-L40).\n-
If any of the tours in the queue are skipped, the remaining tours
are\nalso skipped (currently only Side Nav tour handles skip
behaviour).\nSkipped status is not persisted for now, it is only honored
until page\nreload.\n- Side Nav and Security tours were updated to use
the new tour queue\nsystem.\n\n### Testing\n\nTour completion (Spaces +
SideNav +
Security):\n\n\nhttps://github.com/user-attachments/assets/139847ac-48ea-41e6-8eba-cf5c4981ed96\n\nTour
skipping (Spaces +
SideNav):\n\n\nhttps://github.com/user-attachments/assets/e75f7aa0-6cb4-4c43-9117-172f88f1fe8b","sha":"60952a0bbdeb09c931eaf4469c01f21931836651"}},"sourceBranch":"main","suggestedTargetBranches":["9.2"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242640","number":242640,"mergeCommit":{"message":"[SharedUX]
Add kbn-tour-queue package to avoid tour overlapping (elastic#242640)\n\nCloses
https://github.com/elastic/kibana-team/issues/2146\n\n## Summary\n\n-
This PR introduces a new package to orchestrate tours to
avoid\noverlapping. Currently, Side Nav Tour and Security tour are
overlapping\nin this way:\n\n<img width=\"675\" height=\"391\"
alt=\"Screenshot 2025-11-12 at 10 32
34\"\nsrc=\"https://github.com/user-attachments/assets/27a3ba52-2c69-4fe0-bf62-18d649354de5\"\n/>\n\n-
Package `kbn-tour-queue` uses `globalThis` to share state
across\nplugins and to ensure only one single instance of the state
manager is\nused. This approach is based on @Dosant
`kbn-developer-toolbar`
[state\nimplementation](https://github.com/elastic/kibana/blob/7518eebd9acaf352f02241901cbeb7129e0a1f32/src/platform/packages/shared/kbn-developer-toolbar/src/hooks/use_toolbar_state.tsx#L14-L40).\n-
If any of the tours in the queue are skipped, the remaining tours
are\nalso skipped (currently only Side Nav tour handles skip
behaviour).\nSkipped status is not persisted for now, it is only honored
until page\nreload.\n- Side Nav and Security tours were updated to use
the new tour queue\nsystem.\n\n### Testing\n\nTour completion (Spaces +
SideNav +
Security):\n\n\nhttps://github.com/user-attachments/assets/139847ac-48ea-41e6-8eba-cf5c4981ed96\n\nTour
skipping (Spaces +
SideNav):\n\n\nhttps://github.com/user-attachments/assets/e75f7aa0-6cb4-4c43-9117-172f88f1fe8b","sha":"60952a0bbdeb09c931eaf4469c01f21931836651"}},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->1 parent 7a98037 commit a6a668b
File tree
21 files changed
+747
-15
lines changed- .github
- packages/kbn-optimizer
- src/platform
- x-pack/solutions/security/plugins/security_solution
- public/siem_migrations/rules/components/tours/setup_guide
21 files changed
+747
-15
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
595 | 595 | | |
596 | 596 | | |
597 | 597 | | |
| 598 | + | |
598 | 599 | | |
599 | 600 | | |
600 | 601 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1058 | 1058 | | |
1059 | 1059 | | |
1060 | 1060 | | |
| 1061 | + | |
1061 | 1062 | | |
1062 | 1063 | | |
1063 | 1064 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
Lines changed: 86 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
Lines changed: 64 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments