Commit ac4699b
[8.x] [VisLibrary] AnnotGroup listing page papercuts (elastic#205914) (elastic#206283)
# Backport
This will backport the following commits from `main` to `8.x`:
- [[VisLibrary] AnnotGroup listing page papercuts
(elastic#205914)](elastic#205914)
<!--- Backport version: 9.4.3 -->
### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)
<!--BACKPORT [{"author":{"name":"Paulina
Shakirova","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-10T13:38:00Z","message":"[VisLibrary]
AnnotGroup listing page papercuts (elastic#205914)\n\n## Summary\nThis PR fixes
[Annotation groups Listing
Page\nPapercuts](elastic#198731)
and\n[Dashboard Listing
Page\nPapercuts](elastic#198728)
issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon
being invisible while editing functionality is\navailable.\nIn the past
the logic was different - hiding of icon was happening based\non
`isEditable(item)` property, and in the [[Managed content] readonly\nin
library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR
the logic was changed to depend on adding a key `{ edit: {
enabled:\nfalse }` if there is a need to hide the Edit button. What
happened is\nthat the logic should be -> If you don't want to show the
Edit icon, add\n`{ edit: { enabled: false }`, but in the current code,
although there is\nno such key, the pencil stays invisible, because
the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved
to\n`false` when it is `undefined` (when the Edit functionality
isn't\ndisabled.) In this PR I propose an adjustment to this line of
code.\n3. Changed the View Details icon.\n4. Show Reload page toast when
a user changes preferred\n`savedObjects:perPage` in Advanced
Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the
preferred\n`savedObjects:perPage` was less than 10.\n\n<img
width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44
39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img
width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43
30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:SharedUX","backport:prev-minor","papercut"],"title":"[VisLibrary]
AnnotGroup listing page
papercuts","number":205914,"url":"https://github.com/elastic/kibana/pull/205914","mergeCommit":{"message":"[VisLibrary]
AnnotGroup listing page papercuts (elastic#205914)\n\n## Summary\nThis PR fixes
[Annotation groups Listing
Page\nPapercuts](elastic#198731)
and\n[Dashboard Listing
Page\nPapercuts](elastic#198728)
issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon
being invisible while editing functionality is\navailable.\nIn the past
the logic was different - hiding of icon was happening based\non
`isEditable(item)` property, and in the [[Managed content] readonly\nin
library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR
the logic was changed to depend on adding a key `{ edit: {
enabled:\nfalse }` if there is a need to hide the Edit button. What
happened is\nthat the logic should be -> If you don't want to show the
Edit icon, add\n`{ edit: { enabled: false }`, but in the current code,
although there is\nno such key, the pencil stays invisible, because
the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved
to\n`false` when it is `undefined` (when the Edit functionality
isn't\ndisabled.) In this PR I propose an adjustment to this line of
code.\n3. Changed the View Details icon.\n4. Show Reload page toast when
a user changes preferred\n`savedObjects:perPage` in Advanced
Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the
preferred\n`savedObjects:perPage` was less than 10.\n\n<img
width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44
39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img
width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43
30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205914","number":205914,"mergeCommit":{"message":"[VisLibrary]
AnnotGroup listing page papercuts (elastic#205914)\n\n## Summary\nThis PR fixes
[Annotation groups Listing
Page\nPapercuts](elastic#198731)
and\n[Dashboard Listing
Page\nPapercuts](elastic#198728)
issues.\n\n1. Changed the name of the first column\n2. Fixed edit icon
being invisible while editing functionality is\navailable.\nIn the past
the logic was different - hiding of icon was happening based\non
`isEditable(item)` property, and in the [[Managed content] readonly\nin
library\nviews](https://github.com/elastic/kibana/pull/176263/files#diff-e442682471f1021a9126ddcad7e00a0d334e57ac8db512c1c3268e14ecac0074L552)\nPR
the logic was changed to depend on adding a key `{ edit: {
enabled:\nfalse }` if there is a need to hide the Edit button. What
happened is\nthat the logic should be -> If you don't want to show the
Edit icon, add\n`{ edit: { enabled: false }`, but in the current code,
although there is\nno such key, the pencil stays invisible, because
the\n`Boolean(tableItemsRowActions[item.id]?.edit?.enabled)` resolved
to\n`false` when it is `undefined` (when the Edit functionality
isn't\ndisabled.) In this PR I propose an adjustment to this line of
code.\n3. Changed the View Details icon.\n4. Show Reload page toast when
a user changes preferred\n`savedObjects:perPage` in Advanced
Settings.\n5. Fix sorting algorithm that was sorting incorrectly if the
preferred\n`savedObjects:perPage` was less than 10.\n\n<img
width=\"237\" alt=\"Screenshot 2025-01-09 at 13 44
39\"\nsrc=\"https://github.com/user-attachments/assets/77a6fd45-8845-4b06-818c-0af0dc01ede9\"\n/>\n\n<img
width=\"243\" alt=\"Screenshot 2025-01-09 at 13 43
30\"\nsrc=\"https://github.com/user-attachments/assets/3d9e03da-94dd-4e31-b33a-eb81e71b69dd\"\n/>","sha":"86e8a2fceeb24c83f52d421c18600811ac028ef4"}}]}]
BACKPORT-->
Co-authored-by: Paulina Shakirova <[email protected]>1 parent 037207e commit ac4699b
File tree
5 files changed
+6
-8
lines changed- src/platform
- x-pack/platform/plugins/private/translations/translations
5 files changed
+6
-8
lines changedLines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
299 | 299 | | |
300 | 300 | | |
301 | 301 | | |
302 | | - | |
| 302 | + | |
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
| |||
421 | 421 | | |
422 | 422 | | |
423 | 423 | | |
424 | | - | |
| 424 | + | |
425 | 425 | | |
426 | 426 | | |
427 | 427 | | |
| |||
606 | 606 | | |
607 | 607 | | |
608 | 608 | | |
609 | | - | |
| 609 | + | |
610 | 610 | | |
611 | 611 | | |
612 | 612 | | |
| |||
696 | 696 | | |
697 | 697 | | |
698 | 698 | | |
699 | | - | |
| 699 | + | |
700 | 700 | | |
701 | 701 | | |
702 | 702 | | |
| |||
722 | 722 | | |
723 | 723 | | |
724 | 724 | | |
725 | | - | |
| 725 | + | |
726 | 726 | | |
727 | 727 | | |
728 | 728 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
605 | 605 | | |
606 | 606 | | |
607 | 607 | | |
608 | | - | |
609 | 608 | | |
610 | 609 | | |
611 | 610 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
607 | 607 | | |
608 | 608 | | |
609 | 609 | | |
610 | | - | |
611 | 610 | | |
612 | 611 | | |
613 | 612 | | |
| |||
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
633 | 633 | | |
634 | 634 | | |
635 | 635 | | |
636 | | - | |
637 | 636 | | |
638 | 637 | | |
639 | 638 | | |
| |||
0 commit comments