Skip to content

Commit b3a4fb5

Browse files
authored
Fixing type issue (#290)
* Removing duplicate property in consumer options * Release prepare
1 parent 2c86ea4 commit b3a4fb5

File tree

4 files changed

+9
-12
lines changed

4 files changed

+9
-12
lines changed

packages/kafka/lib/AbstractKafkaConsumer.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,15 @@ import { AbstractKafkaService, type BaseKafkaOptions } from './AbstractKafkaServ
1919
import { KafkaHandlerContainer } from './handler-container/KafkaHandlerContainer.ts'
2020
import type { KafkaHandlerRouting } from './handler-container/KafkaHandlerRoutingBuilder.ts'
2121
import type { KafkaHandler, RequestContext } from './handler-container/index.ts'
22-
import type { KafkaDependencies, TopicConfig } from './types.ts'
22+
import type { KafkaConfig, KafkaDependencies, TopicConfig } from './types.ts'
2323

2424
export type KafkaConsumerDependencies = KafkaDependencies &
2525
Pick<QueueConsumerDependencies, 'transactionObservabilityManager'>
2626

2727
export type KafkaConsumerOptions<TopicsConfig extends TopicConfig[]> = BaseKafkaOptions &
2828
Omit<
2929
ConsumerOptions<string, object, string, string>,
30-
'deserializers' | 'autocommit' | 'bootstrapBrokers'
30+
'deserializers' | 'autocommit' | keyof KafkaConfig
3131
> &
3232
Omit<ConsumeOptions<string, object, string, string>, 'topics'> & {
3333
handlers: KafkaHandlerRouting<TopicsConfig>

packages/kafka/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@message-queue-toolkit/kafka",
3-
"version": "0.1.1",
3+
"version": "0.1.2",
44
"engines": {
55
"node": ">= 22.14.0"
66
},

packages/kafka/test/consumer/PermissionConsumer.spec.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,11 @@ describe('PermissionConsumer', () => {
8080
// Given
8181
consumer = new PermissionConsumer(testContext.cradle, {
8282
// port 9090 is not valid
83-
kafka: { bootstrapBrokers: ['localhost:9090'], clientId: randomUUID() },
84-
connectTimeout: 10, // Short timeout to trigger failure quick
83+
kafka: {
84+
bootstrapBrokers: ['localhost:9090'],
85+
clientId: randomUUID(),
86+
connectTimeout: 10, // Short timeout to trigger failure quick
87+
},
8588
})
8689

8790
// When - Then

packages/kafka/test/consumer/PermissionConsumer.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,7 @@ import { getKafkaConfig } from '../utils/testContext.js'
2020
export type PermissionConsumerOptions = Partial<
2121
Pick<
2222
KafkaConsumerOptions<typeof PERMISSION_TOPIC_MESSAGES_CONFIG>,
23-
| 'kafka'
24-
| 'handlerSpy'
25-
| 'autocreateTopics'
26-
| 'handlers'
27-
| 'connectTimeout'
28-
| 'headerRequestIdField'
23+
'kafka' | 'handlerSpy' | 'autocreateTopics' | 'handlers' | 'headerRequestIdField'
2924
>
3025
>
3126

@@ -73,7 +68,6 @@ export class PermissionConsumer extends AbstractKafkaConsumer<
7368
)
7469
.build(),
7570
autocreateTopics: options.autocreateTopics ?? true,
76-
clientId: randomUUID(),
7771
groupId: randomUUID(),
7872
kafka: options.kafka ?? getKafkaConfig(),
7973
logMessages: true,

0 commit comments

Comments
 (0)