Skip to content

Commit d2f12bd

Browse files
authored
Improve newrelic transaction name (#307)
* Fix docker conflicts with Kafka * Improve newrelic transaction name * release prepare
1 parent 079f2d0 commit d2f12bd

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

docker-compose.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ services:
3939

4040
kafka:
4141
image: apache/kafka:3.7.1
42-
container_name: kafka
4342
ports:
4443
- 9092:9092
4544
environment:
@@ -59,7 +58,6 @@ services:
5958
restart: on-failure
6059

6160
kafka-ui:
62-
container_name: kafka-ui
6361
image: provectuslabs/kafka-ui:latest
6462
ports:
6563
- 8080:8080

packages/kafka/lib/AbstractKafkaConsumer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,7 @@ export abstract class AbstractKafkaConsumer<
258258
private buildTransactionName(message: Message<string, object, string, string>) {
259259
const messageType = this.resolveMessageType(message.value)
260260

261-
let name = `kafka:${message.topic}`
261+
let name = `kafka:${this.constructor.name}:${message.topic}`
262262
if (messageType?.trim().length) name += `:${messageType.trim()}`
263263

264264
return name

packages/kafka/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@message-queue-toolkit/kafka",
3-
"version": "0.2.1",
3+
"version": "0.2.2",
44
"engines": {
55
"node": ">= 22.14.0"
66
},

packages/kafka/test/consumer/PermissionConsumer.spec.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -308,11 +308,17 @@ describe('PermissionConsumer', () => {
308308

309309
// Then
310310
await consumer.handlerSpy.waitForMessageWithId('1', 'consumed')
311-
expect(startTransactionSpy).toHaveBeenCalledWith('kafka:permission-general:added', '1')
311+
expect(startTransactionSpy).toHaveBeenCalledWith(
312+
'kafka:PermissionConsumer:permission-general:added',
313+
'1',
314+
)
312315
expect(stopTransactionSpy).toHaveBeenCalledWith('1')
313316

314317
await consumer.handlerSpy.waitForMessageWithId('2', 'consumed')
315-
expect(startTransactionSpy).toHaveBeenCalledWith('kafka:permission-general', '2')
318+
expect(startTransactionSpy).toHaveBeenCalledWith(
319+
'kafka:PermissionConsumer:permission-general',
320+
'2',
321+
)
316322
expect(stopTransactionSpy).toHaveBeenCalledWith('2')
317323
})
318324

0 commit comments

Comments
 (0)