[MBL-2829] Stop trying to open unrecognized ksr urls in safari (#2635)

* Stop trying to open unrecognized ksr urls in safari

* Add firebase crashlytics non-fatal logging

Author: ifosli

Kickstarter-iOS/AppDelegateViewModel.swift

@@ -1,3 +1,4 @@
+import FirebaseCrashlytics
 import KsApi
 import Library
 import Prelude
@@ -550,13 +551,11 @@ public final class AppDelegateViewModel: AppDelegateViewModelType, AppDelegateVi
       .filter { $0 == .tab(.me) }
       .ignoreValues()
 
-    let resolvedRedirectUrl = Signal.merge(
+    self.goToMobileSafari = Signal.merge(
       deepLinkUrl,
       urlFromBraze
     )
-    .filter { Navigation.deepLinkMatch($0) == nil }
-
-    self.goToMobileSafari = resolvedRedirectUrl
+    .filter(shouldOpenUrlInBrowser)
 
     let projectRootLink = Signal.merge(projectLink, projectPreviewLink)
       .filter { _, subpage, _, _ in subpage == .root }
@@ -1026,6 +1025,28 @@ private func deviceToken(fromData data: Data) -> String {
     .joined()
 }
 
+private func shouldOpenUrlInBrowser(_ url: URL) -> Bool {
+  // If url has a deeplink match, never attempt to open the url in the browser.
+  if Navigation.deepLinkMatch(url) != nil {
+    return false
+  }
+  // Never attempt to open `ksr` urls in the browser; they'll redirect straight back to our app.
+  if let scheme = url.scheme, scheme == "ksr" {
+    print(
+      "Error: Unable to open 'ksr' deeplink. Please doublecheck that the url "
+        + "is included in the list of deeplinks and that you're not trying to "
+        + "use a staging url in prod (or vice versa)."
+    )
+    let error = NSError(domain: "Kickstarter.Deeplink", code: 0, userInfo: [
+      NSLocalizedDescriptionKey: "Unable to open unsupported ksr deeplink."
+    ])
+    Crashlytics.crashlytics().record(error: error)
+    return false
+  }
+  // Otherwise, open url in browser.
+  return true
+}
+
 private func navigation(fromPushEnvelope envelope: PushEnvelope) -> Navigation? {
   if let activity = envelope.activity {
     switch activity.category {

Kickstarter-iOS/AppDelegateViewModelTests.swift

@@ -2571,6 +2571,54 @@ final class AppDelegateViewModelTests: TestCase {
     self.presentViewController.assertValues([])
   }
 
+  func testGoToMobileSafari_unrecognizedDeeplink() {
+    self.vm.inputs.applicationDidFinishLaunching(
+      application: UIApplication.shared,
+      launchOptions: [:]
+    )
+
+    let url = URL(string: "https://fake-url.com")!
+    _ = self.vm.inputs.applicationOpenUrl(application: nil, url: url, options: [:])
+
+    self.goToMobileSafari.assertLastValue(url)
+  }
+
+  func testGoToMobileSafari_deeplinkFound() {
+    self.vm.inputs.applicationDidFinishLaunching(
+      application: UIApplication.shared,
+      launchOptions: [:]
+    )
+
+    let url = URL(string: "https://kickstarter.com/activity")!
+    _ = self.vm.inputs.applicationOpenUrl(application: nil, url: url, options: [:])
+
+    self.goToMobileSafari.assertDidNotEmitValue()
+  }
+
+  func testGoToMobileSafari_ksrUnrecognizedDeeplink() throws {
+    self.vm.inputs.applicationDidFinishLaunching(
+      application: UIApplication.shared,
+      launchOptions: [:]
+    )
+
+    let url = URL(string: "ksr://fake-url.com")!
+    _ = self.vm.inputs.applicationOpenUrl(application: nil, url: url, options: [:])
+
+    self.goToMobileSafari.assertDidNotEmitValue()
+  }
+
+  func testGoToMobileSafari_ksrDeeplinkFound() {
+    self.vm.inputs.applicationDidFinishLaunching(
+      application: UIApplication.shared,
+      launchOptions: [:]
+    )
+
+    let url = URL(string: "https://kickstarter.com/activity")!
+    _ = self.vm.inputs.applicationOpenUrl(application: nil, url: url, options: [:])
+
+    self.goToMobileSafari.assertDidNotEmitValue()
+  }
+
   func testRemoteConfigClientConfiguredNotification_Success() {
     let mockService = MockService(serverConfig: ServerConfig.staging)