Skip to content

Commit a748afb

Browse files
committed
update tests
1 parent f52f4bd commit a748afb

File tree

3 files changed

+29
-14
lines changed

3 files changed

+29
-14
lines changed

Library/Tracking/KSRAnalyticsTests.swift

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,10 @@ final class KSRAnalyticsTests: TestCase {
302302
project.stats.percentFunded,
303303
segmentClientProperties?["project_percent_raised"] as? Int
304304
)
305-
XCTAssertEqual(project.category.analyticsName, segmentClientProperties?["project_subcategory"] as? String)
305+
XCTAssertEqual(
306+
project.category?.analyticsName,
307+
segmentClientProperties?["project_subcategory"] as? String
308+
)
306309
XCTAssertEqual("Art", segmentClientProperties?["project_category"] as? String)
307310
XCTAssertEqual(String(project.creator.id), segmentClientProperties?["project_creator_uid"] as? String)
308311
XCTAssertEqual(24 * 15, segmentClientProperties?["project_hours_remaining"] as? Int)
@@ -451,7 +454,10 @@ final class KSRAnalyticsTests: TestCase {
451454

452455
let segmentClientProperties = segmentClient.properties.last
453456

454-
XCTAssertEqual(project.category.analyticsName, segmentClientProperties?["project_subcategory"] as? String)
457+
XCTAssertEqual(
458+
project.category?.analyticsName,
459+
segmentClientProperties?["project_subcategory"] as? String
460+
)
455461
XCTAssertEqual("Art", segmentClientProperties?["project_category"] as? String)
456462
}
457463

Library/ViewModels/DiscoveryPostcardViewModelTests.swift

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,8 @@ internal final class DiscoveryPostcardViewModelTests: TestCase {
105105
let backedProject = .template
106106
|> Project.lens.personalization.isBacking .~ true
107107

108-
let featuredProject = Project.template
109-
|> \.category.parentId .~ Project.Category.art.id
110-
|> \.category.parentName .~ Project.Category.art.name
108+
let featuredProject = .template
109+
|> \.category .~ Project.Category.art
111110
|> Project.lens.dates.featuredAt .~ featuredAt
112111

113112
let backedColor: UIColor = LegacyColors.ksr_create_700.uiColor()
@@ -143,7 +142,7 @@ internal final class DiscoveryPostcardViewModelTests: TestCase {
143142
self.metadataIconTintColor.assertValues([backedColor])
144143

145144
self.vm.inputs.configure(with: (featuredProject, nil, nil))
146-
guard let parentName = featuredProject.category.parentName else { return }
145+
guard let parentName = featuredProject.category?.parentName else { return }
147146
self.metadataLabelText.assertValues(
148147
[
149148
Strings.discovery_baseball_card_metadata_backer(),

Library/ViewModels/PledgeViewModelTests.swift

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4398,11 +4398,16 @@ final class PledgeViewModelTests: TestCase {
43984398
}
43994399

44004400
func testTrackingEvents_PledgeScreenViewed_LoggedOut() {
4401+
let category = Project.Category(
4402+
analyticsName: Project.Category.illustration.name,
4403+
id: Project.Category.art.id,
4404+
name: Project.Category.illustration.name,
4405+
parentId: Project.Category.art.id,
4406+
parentName: Project.Category.art.name
4407+
)
4408+
44014409
let project = Project.template
4402-
|> \.category.analyticsName .~ Project.Category.illustration.name
4403-
|> \.category.name .~ Project.Category.illustration.name
4404-
|> \.category.parentId .~ Project.Category.art.id
4405-
|> \.category.parentName .~ Project.Category.art.name
4410+
|> \.category .~ category
44064411

44074412
let reward = Reward.template
44084413

@@ -4460,11 +4465,16 @@ final class PledgeViewModelTests: TestCase {
44604465
)
44614466

44624467
withEnvironment(currentUser: user, ksrAnalytics: ksrAnalytics) {
4468+
let category = Project.Category(
4469+
analyticsName: Project.Category.illustration.name,
4470+
id: Project.Category.art.id,
4471+
name: Project.Category.illustration.name,
4472+
parentId: Project.Category.art.id,
4473+
parentName: Project.Category.art.name
4474+
)
4475+
44634476
let project = Project.template
4464-
|> \.category.name .~ Project.Category.illustration.name
4465-
|> \.category.analyticsName .~ Project.Category.illustration.name
4466-
|> \.category.parentId .~ Project.Category.art.id
4467-
|> \.category.parentName .~ Project.Category.art.name
4477+
|> \.category .~ category
44684478
|> Project.lens.stats.userCurrency .~ "USD"
44694479
|> \.personalization.isStarred .~ true
44704480

0 commit comments

Comments
 (0)