[MBL-2755] Update Facebook SDK (#2611)

* Update Facebook SDK version

* Update Facebook API usage

* Isolate Facebook dependency to Library to prevent double symbols

* Fix missing import

Author: stevestreza-ksr

Kickstarter-iOS/AppDelegate.swift

@@ -1,6 +1,5 @@
 import BrazeKit
 import BrazeUI
-import FBSDKCoreKit
 import Firebase
 import Foundation
 import KDS
@@ -42,8 +41,12 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate {
     didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?
   ) -> Bool {
     // FBSDK initialization
-    ApplicationDelegate.shared.application(application, didFinishLaunchingWithOptions: launchOptions)
-    Settings.shouldLimitEventAndDataUsage = true
+    let facebookAppID = Bundle.main.infoDictionary?["FacebookAppID"] as? String
+    AppEnvironment.configureFacebookSDK(
+      appID: facebookAppID,
+      application: application,
+      launchOptions: launchOptions
+    )
 
     // Braze expects to be configured immediately, but segment destination plugins are initialized
     // async. This method bridges that gap.
@@ -334,7 +337,7 @@ internal final class AppDelegate: UIResponder, UIApplicationDelegate {
     options: [UIApplication.OpenURLOptionsKey: Any] = [:]
   ) -> Bool {
     // If this is not a Facebook login call, handle the potential deep-link
-    guard !ApplicationDelegate.shared.application(app, open: url, options: options) else {
+    guard !AppEnvironment.current.facebookSDK.handleOpenURL(app, open: url, options: options) else {
       return true
     }
 

Kickstarter-iOS/Features/Activities/Views/Cells/FindFriendsFacebookConnectCell.swift

@@ -1,4 +1,4 @@
-import FBSDKLoginKit
+import FacebookLogin
 import KDS
 import Library
 import Prelude

Kickstarter-iOS/Features/LoginTout/Controller/LoginToutViewController.swift

@@ -1,5 +1,5 @@
 import AuthenticationServices
-import FBSDKLoginKit
+import FacebookLogin
 import Foundation
 import KDS
 import KsApi

Kickstarter.xcodeproj/project.pbxproj

@@ -1210,6 +1210,10 @@
 		A7FC8C061C8F1DEA00C3B49B /* CircleAvatarImageView.swift in Sources */ = {isa = PBXBuildFile; fileRef = A7FC8C051C8F1DEA00C3B49B /* CircleAvatarImageView.swift */; };
 		AA1023E42CABD2AE007800B5 /* PPOContainerViewModel.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA1023E32CABD2AE007800B5 /* PPOContainerViewModel.swift */; };
 		AA3EB8432CF687680018C880 /* ServerFeature+Helpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA3EB8422CF687680018C880 /* ServerFeature+Helpers.swift */; };
+		AA4533642E7A2B6500B569E8 /* FacebookSDKType.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA4533632E7A2B6500B569E8 /* FacebookSDKType.swift */; };
+		AA4533652E7A2B6500B569E8 /* FacebookSDK.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA4533622E7A2B6500B569E8 /* FacebookSDK.swift */; };
+		AA4533682E7A2C0A00B569E8 /* MockFacebookSDK.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA4533672E7A2C0A00B569E8 /* MockFacebookSDK.swift */; };
+		AA4533692E7A2C0A00B569E8 /* FacebookSDKTypeTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA4533662E7A2C0A00B569E8 /* FacebookSDKTypeTests.swift */; };
 		AA645E972C770D620034705A /* DesignSystemViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6049D0102A9CF6840015BB0D /* DesignSystemViewController.swift */; };
 		AA645E9C2C7725FB0034705A /* PagedContainerViewModelTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA645E9A2C7725FB0034705A /* PagedContainerViewModelTests.swift */; };
 		AA645E9E2C772C650034705A /* PagedTabBarTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = AA645E9D2C772C650034705A /* PagedTabBarTests.swift */; };
@@ -2967,6 +2971,10 @@
 		A7FC8C051C8F1DEA00C3B49B /* CircleAvatarImageView.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = CircleAvatarImageView.swift; sourceTree = "<group>"; };
 		AA1023E32CABD2AE007800B5 /* PPOContainerViewModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PPOContainerViewModel.swift; sourceTree = "<group>"; };
 		AA3EB8422CF687680018C880 /* ServerFeature+Helpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "ServerFeature+Helpers.swift"; sourceTree = "<group>"; };
+		AA4533622E7A2B6500B569E8 /* FacebookSDK.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FacebookSDK.swift; sourceTree = "<group>"; };
+		AA4533632E7A2B6500B569E8 /* FacebookSDKType.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FacebookSDKType.swift; sourceTree = "<group>"; };
+		AA4533662E7A2C0A00B569E8 /* FacebookSDKTypeTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FacebookSDKTypeTests.swift; sourceTree = "<group>"; };
+		AA4533672E7A2C0A00B569E8 /* MockFacebookSDK.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockFacebookSDK.swift; sourceTree = "<group>"; };
 		AA645E9A2C7725FB0034705A /* PagedContainerViewModelTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PagedContainerViewModelTests.swift; sourceTree = "<group>"; };
 		AA645E9D2C772C650034705A /* PagedTabBarTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PagedTabBarTests.swift; sourceTree = "<group>"; };
 		AA6682222CB86EEB00C8522E /* PPOProjectCardModel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = PPOProjectCardModel.swift; sourceTree = "<group>"; };
@@ -6547,6 +6555,8 @@
 				77556F1C20A09993008CEA57 /* ExperimentName+Helpers.swift */,
 				D667C2BB2305F03300EC094A /* ExperimentName+HelpersTests.swift */,
 				77216CAB20EFE7F70061BE82 /* FacebookConnectionType.swift */,
+				AA4533622E7A2B6500B569E8 /* FacebookSDK.swift */,
+				AA4533632E7A2B6500B569E8 /* FacebookSDKType.swift */,
 				8AF91CDC22EF5AF7005F9C90 /* Feature.swift */,
 				A7C725801C85D36D005A016B /* Format.swift */,
 				A7ED1F151E830FDC00BFFA01 /* FormatTests.swift */,
@@ -6579,6 +6589,8 @@
 				D0200A5321935EDF00F5CC27 /* MessageBannerType.swift */,
 				8A3BF51D23F5DB52002AD818 /* MockCoreTelephonyNetworkInfo.swift */,
 				D093B4B721A8B0E000910962 /* MockPushRegistration.swift */,
+				AA4533662E7A2C0A00B569E8 /* FacebookSDKTypeTests.swift */,
+				AA4533672E7A2C0A00B569E8 /* MockFacebookSDK.swift */,
 				606C45F929FACE17001BA067 /* MockRemoteConfigClient.swift */,
 				80E26A121D500C6A007B3022 /* Navigation.swift */,
 				77D19FF4240813240058FC8E /* NavigationController.swift */,
@@ -8645,6 +8657,8 @@
 				77F6E73721222E97005A5C55 /* SettingsCellType.swift in Sources */,
 				D703FC6B20F7E3F8004A272D /* SettingsPrivacyViewModel.swift in Sources */,
 				8A4DDAB52373429300ADE31D /* PledgeStatusLabelViewModel.swift in Sources */,
+				AA4533642E7A2B6500B569E8 /* FacebookSDKType.swift in Sources */,
+				AA4533652E7A2B6500B569E8 /* FacebookSDK.swift in Sources */,
 				0169F9881D6F51C400C8D5C5 /* DiscoveryFiltersViewModel.swift in Sources */,
 				94C92E8A2659F09A00A96818 /* PaddingLabel.swift in Sources */,
 				01FD71EC1D3808E500070BAC /* BarButtonItemStyles.swift in Sources */,
@@ -8990,6 +9004,8 @@
 				A78355B91E85BD2D0021DA5A /* ActivityFriendFollowCellViewModelTests.swift in Sources */,
 				A7ED1FF01E831C5C00BFFA01 /* MessagesViewModelTests.swift in Sources */,
 				77BC00F82330236600808E75 /* RewardCellViewModelTests.swift in Sources */,
+				AA4533682E7A2C0A00B569E8 /* MockFacebookSDK.swift in Sources */,
+				AA4533692E7A2C0A00B569E8 /* FacebookSDKTypeTests.swift in Sources */,
 				3344A7812D9C973400D7DE91 /* RewardTrackingDetailsViewModelTest.swift in Sources */,
 				A7ED1FC91E831C5C00BFFA01 /* ActivitiesViewModelTests.swift in Sources */,
 				A7ED1FD21E831C5C00BFFA01 /* LoginToutViewModelTests.swift in Sources */,
@@ -11774,7 +11790,7 @@
 			repositoryURL = "https://github.com/facebook/facebook-ios-sdk";
 			requirement = {
 				kind = upToNextMajorVersion;
-				minimumVersion = 9.0.0;
+				minimumVersion = 12.0.0;
 			};
 		};
 		60DA50F628BFA331002E2DF1 /* XCRemoteSwiftPackageReference "AlamofireImage" */ = {

Kickstarter.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -1,4 +1,4 @@
-import FBSDKCoreKit
+import FacebookCore
 import FirebaseCrashlytics
 import Foundation
 import KsApi
@@ -102,6 +102,26 @@ public struct AppEnvironment: AppEnvironmentType {
     self.replaceCurrentEnvironment(language: language)
   }
 
+  public static func configureFacebookSDK(
+    appID: String?,
+    application: UIApplication,
+    launchOptions: [UIApplication.LaunchOptionsKey: Any]?
+  ) {
+    self.current.facebookSDK.configure(
+      appID: appID,
+      application: application,
+      launchOptions: launchOptions
+    )
+  }
+
+  public static func didFacebookSDKOpenURL(
+    _ app: UIApplication,
+    open url: URL,
+    options: [UIApplication.OpenURLOptionsKey: Any] = [:]
+  ) -> Bool {
+    return self.current.facebookSDK.handleOpenURL(app, open: url, options: options)
+  }
+
   // Invoke when you want to end the user's session.
   public static func logout() {
     let storage = AppEnvironment.current.cookieStorage
@@ -185,6 +205,7 @@ public struct AppEnvironment: AppEnvironmentType {
     debounceInterval: DispatchTimeInterval = AppEnvironment.current.debounceInterval,
     debugData: DebugData? = AppEnvironment.current.debugData,
     device: UIDeviceType = AppEnvironment.current.device,
+    facebookSDK: FacebookSDKType.Type = AppEnvironment.current.facebookSDK,
     isVoiceOverRunning: @escaping (() -> Bool) = AppEnvironment.current.isVoiceOverRunning,
     ksrAnalytics: KSRAnalytics = AppEnvironment.current.ksrAnalytics,
     language: Language = AppEnvironment.current.language,
@@ -218,6 +239,7 @@ public struct AppEnvironment: AppEnvironmentType {
         debounceInterval: debounceInterval,
         debugData: debugData,
         device: device,
+        facebookSDK: facebookSDK,
         isVoiceOverRunning: isVoiceOverRunning,
         ksrAnalytics: ksrAnalytics,
         language: language,
@@ -258,6 +280,7 @@ public struct AppEnvironment: AppEnvironmentType {
     debounceInterval: DispatchTimeInterval = AppEnvironment.current.debounceInterval,
     debugData: DebugData? = AppEnvironment.current.debugData,
     device: UIDeviceType = AppEnvironment.current.device,
+    facebookSDK: FacebookSDKType.Type = AppEnvironment.current.facebookSDK,
     isVoiceOverRunning: @escaping (() -> Bool) = AppEnvironment.current.isVoiceOverRunning,
     ksrAnalytics: KSRAnalytics = AppEnvironment.current.ksrAnalytics,
     language: Language = AppEnvironment.current.language,
@@ -294,6 +317,7 @@ public struct AppEnvironment: AppEnvironmentType {
         debounceInterval: debounceInterval,
         debugData: debugData,
         device: device,
+        facebookSDK: facebookSDK,
         isVoiceOverRunning: isVoiceOverRunning,
         ksrAnalytics: ksrAnalytics,
         language: language,

Library/AppEnvironment.swift

@@ -1,6 +1,6 @@
 import AVFoundation
 import CoreTelephony
-import FBSDKCoreKit
+import FacebookCore
 import Foundation
 import KsApi
 import ReactiveSwift
@@ -77,6 +77,9 @@ public struct Environment {
   /// The environment variables
   public let environmentVariables: EnvironmentVariables
 
+  /// A type that manages Facebook SDK operations.
+  public let facebookSDK: FacebookSDKType.Type
+
   /// A function that returns whether VoiceOver mode is running.
   public let isVoiceOverRunning: () -> Bool
 
@@ -140,6 +143,7 @@ public struct Environment {
     debugData: DebugData? = nil,
     device: UIDeviceType = UIDevice.current,
     environmentVariables: EnvironmentVariables = EnvironmentVariables(),
+    facebookSDK: FacebookSDKType.Type = FacebookSDK.self,
     isVoiceOverRunning: @escaping () -> Bool = { UIAccessibility.isVoiceOverRunning },
     ksrAnalytics: KSRAnalytics = KSRAnalytics(),
     language: Language = Language(languageStrings: Locale.preferredLanguages) ?? Language.en,
@@ -175,6 +179,7 @@ public struct Environment {
     self.debugData = debugData
     self.device = device
     self.environmentVariables = environmentVariables
+    self.facebookSDK = facebookSDK
     self.isVoiceOverRunning = isVoiceOverRunning
     self.ksrAnalytics = ksrAnalytics
     self.language = language

Library/Environment.swift

@@ -0,0 +1,27 @@
+import FacebookCore
+import Foundation
+import UIKit
+
+/// Concrete implementation of FacebookSDKType using FacebookCore
+public enum FacebookSDK: FacebookSDKType {
+  public static func configure(
+    appID: String?,
+    application: UIApplication,
+    launchOptions: [UIApplication.LaunchOptionsKey: Any]?
+  ) {
+    FacebookCore.Settings.shared.isEventDataUsageLimited = true
+    FacebookCore.Settings.shared.appID = appID
+    FacebookCore.ApplicationDelegate.shared.application(
+      application,
+      didFinishLaunchingWithOptions: launchOptions
+    )
+  }
+
+  public static func handleOpenURL(
+    _ app: UIApplication,
+    open url: URL,
+    options: [UIApplication.OpenURLOptionsKey: Any]
+  ) -> Bool {
+    return FacebookCore.ApplicationDelegate.shared.application(app, open: url, options: options)
+  }
+}

Library/FacebookSDK.swift

@@ -0,0 +1,19 @@
+import Foundation
+import UIKit
+
+/// Protocol defining Facebook SDK operations for login and URL handling
+public protocol FacebookSDKType {
+  /// Configure the Facebook SDK with app ID and launch options
+  static func configure(
+    appID: String?,
+    application: UIApplication,
+    launchOptions: [UIApplication.LaunchOptionsKey: Any]?
+  )
+
+  /// Handle URL opening for Facebook SDK
+  static func handleOpenURL(
+    _ app: UIApplication,
+    open url: URL,
+    options: [UIApplication.OpenURLOptionsKey: Any]
+  ) -> Bool
+}

Library/FacebookSDKType.swift

@@ -0,0 +1,73 @@
+import Foundation
+@testable import Library
+import UIKit
+import XCTest
+
+final class FacebookSDKTypeTests: XCTestCase {
+  override func setUp() {
+    super.setUp()
+    MockFacebookSDK.reset()
+  }
+
+  func testMockFacebookSDKConfigure() {
+    // Given
+    let appID = "test_app_id"
+    let application = UIApplication.shared
+    let launchOptions: [UIApplication.LaunchOptionsKey: Any]? = [.init(rawValue: "test"): "value"]
+
+    // When
+    MockFacebookSDK.configure(
+      appID: appID,
+      application: application,
+      launchOptions: launchOptions
+    )
+
+    // Then
+    XCTAssertTrue(MockFacebookSDK.configureCalled)
+    XCTAssertEqual(MockFacebookSDK.configureAppID, appID)
+    XCTAssertEqual(MockFacebookSDK.configureApplication, application)
+    XCTAssertEqual(MockFacebookSDK.configureLaunchOptions?[.init(rawValue: "test")] as? String, "value")
+  }
+
+  func testMockFacebookSDKHandleOpenURL() {
+    // Given
+    let application = UIApplication.shared
+    let url = URL(string: "https://example.com")!
+    let options: [UIApplication.OpenURLOptionsKey: Any] = [.init(rawValue: "test"): "value"]
+    MockFacebookSDK.handleOpenURLReturnValue = true
+
+    // When
+    let result = MockFacebookSDK.handleOpenURL(application, open: url, options: options)
+
+    // Then
+    XCTAssertTrue(MockFacebookSDK.handleOpenURLCalled)
+    XCTAssertEqual(MockFacebookSDK.handleOpenURLApp, application)
+    XCTAssertEqual(MockFacebookSDK.handleOpenURLURL, url)
+    XCTAssertEqual(MockFacebookSDK.handleOpenURLOptions?[.init(rawValue: "test")] as? String, "value")
+    XCTAssertTrue(result)
+  }
+
+  func testMockFacebookSDKReset() {
+    // Given
+    MockFacebookSDK.configure(appID: "test", application: UIApplication.shared, launchOptions: nil)
+    _ = MockFacebookSDK.handleOpenURL(
+      UIApplication.shared,
+      open: URL(string: "https://test.com")!,
+      options: [:]
+    )
+
+    // When
+    MockFacebookSDK.reset()
+
+    // Then
+    XCTAssertFalse(MockFacebookSDK.configureCalled)
+    XCTAssertNil(MockFacebookSDK.configureAppID)
+    XCTAssertNil(MockFacebookSDK.configureApplication)
+    XCTAssertNil(MockFacebookSDK.configureLaunchOptions)
+    XCTAssertFalse(MockFacebookSDK.handleOpenURLCalled)
+    XCTAssertNil(MockFacebookSDK.handleOpenURLApp)
+    XCTAssertNil(MockFacebookSDK.handleOpenURLURL)
+    XCTAssertNil(MockFacebookSDK.handleOpenURLOptions)
+    XCTAssertFalse(MockFacebookSDK.handleOpenURLReturnValue)
+  }
+}