Bug/adyer/mbl 2832/refactor location popup

[amy-at-kickstarter]

📲 What

A description of the change.

🤔 Why

Some background context on why the change is needed.

🛠 How

More in-depth discussion of the change or implementation.

👀 See

Trello, screenshots, external resources?

Before 🐛	After 🦋

♿️ Accessibility

• Tap targets use minimum of 44x44 pts dimensions
• Works with VoiceOver
• Supports Dynamic Type

🏎 Performance

• Optimized Blended Layers (screenshots)

✅ Acceptance criteria

• Steps to test this feature
• Environment to test on
• Issues to look out for

⏰ TODO

• Got planned refactors to come
• Will add more tests
• Need feedback on a design

[nativeksr]

	1 Warning
⚠️	Big PR

SwiftLint found issues

Warnings

File	Line	Reason
RewardsCollectionViewModelTests.swift	155	Function body should span 50 lines or less excluding comments and whitespace: currently spans 58 lines (function_body_length)
RewardsCollectionViewModelTests.swift	9	Class body should span 250 lines or less excluding comments and whitespace: currently spans 260 lines (type_body_length)
PledgeShippingLocationViewModelTests.swift	416	File should contain 400 lines or less: currently contains 416 (file_length)
PledgeShippingLocationViewModelTests.swift	321	Function body should span 50 lines or less excluding comments and whitespace: currently spans 56 lines (function_body_length)
PledgeShippingLocationViewModelTests.swift	10	Class body should span 250 lines or less excluding comments and whitespace: currently spans 301 lines (type_body_length)
PledgeShippingLocationViewModel.swift	39	Initializer body should span 50 lines or less excluding comments and whitespace: currently spans 52 lines (function_body_length)
PledgeShippingLocationViewModel.swift	118	Variable name 'shippingLocationCancelButtonTappedProperty' should be between 3 and 40 characters long (identifier_name)
SharedFunctions.swift	838	File should contain 400 lines or less: currently contains 838 (file_length)

Errors

File	Line	Reason
ShippingLocationsView.swift	6	Function name 'ShippingLocationsViewController(withLocations:selectedLocation:onSelectedLocation:onCancelled:)' should start with a lowercase character (identifier_name)
ShippingLocationsViewModel.swift	32	Variable name 'a' should be between 3 and 40 characters long (identifier_name)
ShippingLocationsViewModel.swift	32	Variable name 'b' should be between 3 and 40 characters long (identifier_name)

Generated by 🚫 Danger