Skip to content

Commit 715a590

Browse files
committed
Prevent dereferencing
1 parent 7471f8f commit 715a590

File tree

1 file changed

+8
-7
lines changed
  • backend/apportionment/src/candidate_nomination

1 file changed

+8
-7
lines changed

backend/apportionment/src/candidate_nomination/mod.rs

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -104,15 +104,16 @@ fn candidate_nomination_per_list<'a, T: ListVotesTrait>(
104104
let (list_number, list_seats) = total_seats
105105
.iter()
106106
.find(|(number, _)| *number == list.number())
107-
.expect("Total seats exists");
108-
let candidate_votes = list.candidate_votes();
107+
.expect("Total seats exists")
108+
.to_owned();
109+
let candidate_votes = &list.candidate_votes();
109110
let candidate_votes_meeting_preference_threshold =
110111
candidate_votes_meeting_preference_threshold(preference_threshold, candidate_votes);
111112
let preferential_candidate_nomination = preferential_candidate_nomination::<T::Cv>(
112113
&candidate_votes_meeting_preference_threshold,
113-
*list_seats,
114+
list_seats,
114115
)?;
115-
let non_assigned_seats = *list_seats as usize - preferential_candidate_nomination.len();
116+
let non_assigned_seats = list_seats as usize - preferential_candidate_nomination.len();
116117

117118
// [Artikel P 17 Kieswet](https://wetten.overheid.nl/BWBR0004627/2026-01-01/#AfdelingII_HoofdstukP_Paragraaf3_ArtikelP17)
118119
let other_candidate_nomination = other_candidate_nomination(
@@ -124,7 +125,7 @@ fn candidate_nomination_per_list<'a, T: ListVotesTrait>(
124125
// [Artikel P 19 Kieswet](https://wetten.overheid.nl/BWBR0004627/2026-01-01/#AfdelingII_HoofdstukP_Paragraaf3_ArtikelP19)
125126
let updated_candidate_ranking: Vec<CandidateNumber> =
126127
if candidate_votes_meeting_preference_threshold.is_empty()
127-
|| (seats >= LARGE_COUNCIL_THRESHOLD && *list_seats == 0)
128+
|| (seats >= LARGE_COUNCIL_THRESHOLD && list_seats == 0)
128129
{
129130
vec![]
130131
} else {
@@ -146,8 +147,8 @@ fn candidate_nomination_per_list<'a, T: ListVotesTrait>(
146147
};
147148

148149
list_candidate_nomination.push(ListCandidateNomination {
149-
list_number: *list_number,
150-
list_seats: *list_seats,
150+
list_number,
151+
list_seats,
151152
preferential_candidate_nomination,
152153
other_candidate_nomination,
153154
updated_candidate_ranking,

0 commit comments

Comments
 (0)