test(core): ✅ test behaviour of disable_inherited_profiles_issue_reporting flag

Author: kikkomep

tests/unit/test_services.py

@@ -106,6 +106,37 @@ def test_valid_local_workflow_testing_ro_crate():
         "Expected the 'workflow-testing-ro-crate-0.1' profile"
 
 
+def test_disable_inherited_profiles_issue_reporting():
+    # Set the rocrate_uri to the workflow testing RO-Crate
+    crate_path = ValidROC().workflow_testing_ro_crate
+    logger.debug("Validating a local RO-Crate: %s", crate_path)
+
+    # First, validate with inherited profiles issue reporting enabled
+    settings = ValidationSettings(
+        rocrate_uri=crate_path,
+        disable_inherited_profiles_issue_reporting=False
+    )
+    result = validate(settings)
+    total_issues_with_inheritance = len(result.get_issues())
+    logger.debug("Total issues with inherited profiles issue reporting enabled: %d", total_issues_with_inheritance)
+
+    # Now, validate with inherited profiles issue reporting disabled
+    settings.disable_inherited_profiles_issue_reporting = True
+    result = validate(settings)
+    total_issues_without_inheritance = len(result.get_issues())
+    logger.debug("Total issues with inherited profiles issue reporting disabled: %d", total_issues_without_inheritance)
+
+    # Check that disabling inherited profiles issue reporting reduces the number of reported issues
+    assert total_issues_without_inheritance <= total_issues_with_inheritance, \
+        "Disabling inherited profiles issue reporting should not increase the number of reported issues"
+
+    # Check that all reported issues are from the main profile
+    main_profile_identifier = "workflow-testing-ro-crate-0.1"
+    for issue in result.get_issues():
+        assert issue.check.profile.identifier == main_profile_identifier, \
+            "All reported issues should belong to the main profile when inherited profiles issue reporting is disabled"
+
+
 def test_valid_local_multi_profile_crate():
     # Set the rocrate_uri to the multi-profile RO-Crate
     crate_path = InvalidMultiProfileROC().invalid_multi_profile_crate

tests/unit/test_validation_settings.py

@@ -23,26 +23,30 @@ def test_validation_settings_parse_dict():
         "profiles_path": "/path/to/profiles",
         "requirement_severity": "RECOMMENDED",
         "enable_profile_inheritance": False,
+        "disable_inherited_profiles_issue_reporting": True,
     }
     settings = ValidationSettings.parse(settings_dict)
     assert str(settings.rocrate_uri) == "/path/to/data"
     assert settings.profiles_path == "/path/to/profiles"
     assert settings.requirement_severity == Severity.RECOMMENDED
     assert settings.enable_profile_inheritance is False
+    assert settings.disable_inherited_profiles_issue_reporting is True
 
 
 def test_validation_settings_parse_object():
     existing_settings = ValidationSettings(
         rocrate_uri="/path/to/data",
         profiles_path="/path/to/profiles",
         requirement_severity=Severity.RECOMMENDED,
-        enable_profile_inheritance=False
+        enable_profile_inheritance=False,
+        disable_inherited_profiles_issue_reporting=True,
     )
     settings = ValidationSettings.parse(existing_settings)
     assert str(settings.rocrate_uri) == "/path/to/data"
     assert settings.profiles_path == "/path/to/profiles"
     assert settings.requirement_severity == Severity.RECOMMENDED
     assert settings.enable_profile_inheritance is False
+    assert settings.disable_inherited_profiles_issue_reporting is True
 
 
 def test_validation_settings_parse_invalid_type():
@@ -72,6 +76,17 @@ def test_validation_settings_enable_profile_inheritance():
     assert settings.enable_profile_inheritance is False
 
 
+def test_validation_settings_disable_inherited_profiles_issue_reporting():
+    settings = ValidationSettings()
+    assert settings.disable_inherited_profiles_issue_reporting is False
+
+    settings = ValidationSettings(disable_inherited_profiles_issue_reporting=True)
+    assert settings.disable_inherited_profiles_issue_reporting is True
+
+    settings = ValidationSettings(disable_inherited_profiles_issue_reporting=False)
+    assert settings.disable_inherited_profiles_issue_reporting is False
+
+
 def test_validation_settings_data_path():
     settings = ValidationSettings(rocrate_uri="/path/to/data")
     assert str(settings.rocrate_uri) == "/path/to/data"