Skip to content

Commit fff137e

Browse files
daxian-dbwmsftbot[bot]
authored andcommitted
Avoid using closure in Parser.SaveError (PowerShell#11006)
1 parent 41e2898 commit fff137e

File tree

1 file changed

+10
-8
lines changed
  • src/System.Management.Automation/engine/parser

1 file changed

+10
-8
lines changed

src/System.Management.Automation/engine/parser/Parser.cs

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7932,16 +7932,18 @@ private ExpressionAst ElementAccessRule(ExpressionAst primaryExpression, Token l
79327932

79337933
private void SaveError(ParseError error)
79347934
{
7935-
if (ErrorList.Any())
7935+
if (ErrorList.Count > 0)
79367936
{
7937-
// Avoiding adding duplicate errors - can happen when the tokenizer resyncs.
7938-
if (ErrorList.Any(err => err.ErrorId.Equals(error.ErrorId, StringComparison.Ordinal)
7939-
&& err.Extent.EndColumnNumber == error.Extent.EndColumnNumber
7940-
&& err.Extent.EndLineNumber == error.Extent.EndLineNumber
7941-
&& err.Extent.StartColumnNumber == error.Extent.StartColumnNumber
7942-
&& err.Extent.StartLineNumber == error.Extent.StartLineNumber))
7937+
foreach (ParseError err in ErrorList)
79437938
{
7944-
return;
7939+
if (err.ErrorId.Equals(error.ErrorId, StringComparison.Ordinal)
7940+
&& err.Extent.EndColumnNumber == error.Extent.EndColumnNumber
7941+
&& err.Extent.EndLineNumber == error.Extent.EndLineNumber
7942+
&& err.Extent.StartColumnNumber == error.Extent.StartColumnNumber
7943+
&& err.Extent.StartLineNumber == error.Extent.StartLineNumber)
7944+
{
7945+
return;
7946+
}
79457947
}
79467948
}
79477949

0 commit comments

Comments
 (0)