Merge pull request #1969 from kili-technology/lab-3898-annotation

chore(LAB-3898): remove deprecated annotation fields

Author: josselinbuils

src/kili/adapters/kili_api_gateway/label/common.py

@@ -42,12 +42,6 @@ def get_annotation_fragment():
         classification_annotation_fragment=fragment_builder(
             ("annotationValue.categories", "chatItemId")
         ),
-        ranking_annotation_fragment=fragment_builder(
-            (
-                "annotationValue.orders.elements",
-                "annotationValue.orders.rank",
-            )
-        ),
         comparison_annotation_fragment=fragment_builder(
             (
                 "annotationValue.choice.code",

src/kili/adapters/kili_api_gateway/label/operations.py

@@ -74,7 +74,6 @@ def get_append_to_labels_mutation(fragment: str) -> str:
 def get_annotations_partial_query(
     annotation_fragment: str,
     classification_annotation_fragment: str,
-    ranking_annotation_fragment: str,
     comparison_annotation_fragment: str,
     transcription_annotation_fragment: str,
     video_annotation_fragment: str,
@@ -93,13 +92,6 @@ def get_annotations_partial_query(
             }}
         """
 
-    if ranking_annotation_fragment.strip():
-        inline_fragments += f"""
-            ... on RankingAnnotation {{
-                {ranking_annotation_fragment}
-            }}
-        """
-
     if comparison_annotation_fragment.strip():
         inline_fragments += f"""
             ... on ComparisonAnnotation {{

src/kili/domain/annotation.py

@@ -48,24 +48,6 @@ class RankingOrderValue(TypedDict):
     elements: List[str]
 
 
-class RankingAnnotationValue(TypedDict):
-    """Ranking annotation value."""
-
-    orders: List[RankingOrderValue]
-
-
-class RankingAnnotation(TypedDict):
-    """Ranking annotation."""
-
-    # pylint: disable=unused-private-member
-    __typename: Literal["RankingAnnotation"]
-    id: AnnotationId
-    labelId: LabelId
-    job: JobName
-    path: List[List[str]]
-    annotationValue: RankingAnnotationValue
-
-
 class TranscriptionAnnotationValue(TypedDict):
     """Transcription annotation value."""
 
@@ -190,13 +172,11 @@ class VideoTranscriptionAnnotation(TypedDict):
 ClassicAnnotation = Union[
     ClassificationAnnotation,
     ObjectDetectionAnnotation,
-    RankingAnnotation,
     TranscriptionAnnotation,
 ]
 
 Annotation = Union[
     ClassificationAnnotation,
-    RankingAnnotation,
     TranscriptionAnnotation,
     VideoAnnotation,
 ]

tests/unit/adapters/kili_api_gateway/label/test_data/test_case_14.py

@@ -13,13 +13,6 @@
             "required": 0,
             "isChild": False,
         },
-        "RANKING_JOB": {
-            "content": {"input": "select"},
-            "instruction": "Ranking Select",
-            "mlTask": "RANKING",
-            "required": 0,
-            "isChild": False,
-        },
         "TRANSCRIPTION_JOB": {
             "content": {"input": "textField"},
             "instruction": "Transcription Text",
@@ -31,23 +24,6 @@
 }
 
 annotations = [
-    {
-        "id": "4eb1c8e2-05fd-42ae-aa17-7c18a803c682",
-        "job": "RANKING_JOB",
-        "path": [],
-        "labelId": "clr53q1as0208kjba8jwcavcx",
-        "annotationValue": {
-            "id": "4eb1c8e2-05fd-42ae-aa17-7c18a803c682",
-            "isPrediction": False,
-            "orders": [
-                {"elements": ["Response 5"], "rank": 1, "__typename": "RankingOrderValue"},
-                {"elements": ["Response 3"], "rank": 3, "__typename": "RankingOrderValue"},
-                {"elements": ["Response 2"], "rank": 2, "__typename": "RankingOrderValue"},
-            ],
-            "__typename": "RankingAnnotationValue",
-        },
-        "__typename": "RankingAnnotation",
-    },
     {
         "id": "8be13b44-dfb5-4456-83b4-710b902f2fa3",
         "job": "CLASSIFICATION_JOB",
@@ -118,13 +94,6 @@
 
 
 expected_json_resp = {
-    "RANKING_JOB": {
-        "orders": [
-            {"elements": ["Response 5"], "rank": 1, "__typename": "RankingOrderValue"},
-            {"elements": ["Response 2"], "rank": 2, "__typename": "RankingOrderValue"},
-            {"elements": ["Response 3"], "rank": 3, "__typename": "RankingOrderValue"},
-        ]
-    },
     "CLASSIFICATION_JOB": {"categories": [{"name": "Choice 1"}]},
     "TRANSCRIPTION_JOB": {"text": "Test Transcription"},
 }

tests/unit/services/export/expected/llm_project_assets.py

@@ -24,13 +24,6 @@
         "isSentBackToQueue": False,
         "jsonResponse": {
             "CLASSIFICATION_JOB": {"categories": [{"name": "Choice 1"}]},
-            "RANKING_JOB": {
-                "orders": [
-                    {"__typename": "RankingOrderValue", "elements": ["Response 5"], "rank": 1},
-                    {"__typename": "RankingOrderValue", "elements": ["Response 2"], "rank": 2},
-                    {"__typename": "RankingOrderValue", "elements": ["Response 3"], "rank": 3},
-                ]
-            },
             "TRANSCRIPTION_JOB": {"text": "Test Transcription"},
         },
         "labelType": "DEFAULT",