feat(LAB-3552): remove support for number_of_(...) fields in updatePr… (#1892)

Removes support to changing number_of_(...) fields of projects through the update_properties_in_project.
These fields are computed server-wise from now on.

Author: BlueGrizzliBear

src/kili/adapters/kili_api_gateway/project/mappers.py

@@ -43,11 +43,7 @@ def project_data_mapper(data: ProjectDataKiliAPIGatewayInput) -> Dict:
         "instructions": data.instructions,
         "jsonInterface": data.json_interface,
         "minConsensusSize": data.min_consensus_size,
-        "numberOfAssets": data.number_of_assets,
         "rules": data.rules,
-        "numberOfSkippedAssets": data.number_of_skipped_assets,
-        "numberOfRemainingAssets": data.number_of_remaining_assets,
-        "numberOfReviewedAssets": data.number_of_reviewed_assets,
         "reviewCoverage": data.review_coverage,
         "shouldAutoAssign": data.should_auto_assign,
         "shouldRelaunchKpiComputation": data.should_relaunch_kpi_computation,

src/kili/adapters/kili_api_gateway/project/types.py

@@ -27,11 +27,7 @@ class ProjectDataKiliAPIGatewayInput:
     metadata_types: Optional[Dict]
     metadata_properties: Optional[Dict]
     min_consensus_size: Optional[int]
-    number_of_assets: Optional[int]
     rules: Optional[str]
-    number_of_skipped_assets: Optional[int]
-    number_of_remaining_assets: Optional[int]
-    number_of_reviewed_assets: Optional[int]
     review_coverage: Optional[int]
     should_auto_assign: Optional[bool]
     should_relaunch_kpi_computation: Optional[bool]

src/kili/entrypoints/mutations/project/queries.py

@@ -26,10 +26,6 @@
     $jsonInterface: String
     $metadataProperties: JSON
     $minConsensusSize: Int
-    $numberOfAssets: Int
-    $numberOfSkippedAssets: Int
-    $numberOfRemainingAssets: Int
-    $numberOfReviewedAssets: Int
     $projectID: ID!
     $reviewCoverage: Int
     $title: String
@@ -52,10 +48,6 @@
       jsonInterface: $jsonInterface
       metadataProperties: $metadataProperties
       minConsensusSize: $minConsensusSize
-      numberOfAssets: $numberOfAssets
-      numberOfSkippedAssets: $numberOfSkippedAssets
-      numberOfRemainingAssets: $numberOfRemainingAssets
-      numberOfReviewedAssets: $numberOfReviewedAssets
       reviewCoverage: $reviewCoverage
       title: $title
       useHoneyPot: $useHoneyPot

src/kili/presentation/client/project.py

@@ -306,10 +306,6 @@ def update_properties_in_project(
         input_type: Optional[InputType] = None,
         json_interface: Optional[dict] = None,
         min_consensus_size: Optional[int] = None,
-        number_of_assets: Optional[int] = None,
-        number_of_skipped_assets: Optional[int] = None,
-        number_of_remaining_assets: Optional[int] = None,
-        number_of_reviewed_assets: Optional[int] = None,
         review_coverage: Optional[int] = None,
         should_relaunch_kpi_computation: Optional[bool] = None,
         title: Optional[str] = None,
@@ -340,10 +336,6 @@ def update_properties_in_project(
             json_interface: The json parameters of the project, see Edit your interface.
             min_consensus_size: Should be between 1 and 10
                 Number of people that will annotate the same asset, for consensus computation.
-            number_of_assets: Defaults to 0
-            number_of_skipped_assets: Defaults to 0
-            number_of_remaining_assets: Defaults to 0
-            number_of_reviewed_assets: Defaults to 0
             review_coverage: Allow to set the percentage of assets
                 that will be queued in the review interface.
                 Should be between 0 and 100
@@ -434,10 +426,6 @@ def update_properties_in_project(
             input_type=input_type,
             json_interface=json_interface,
             min_consensus_size=min_consensus_size,
-            number_of_assets=number_of_assets,
-            number_of_skipped_assets=number_of_skipped_assets,
-            number_of_remaining_assets=number_of_remaining_assets,
-            number_of_reviewed_assets=number_of_reviewed_assets,
             review_coverage=review_coverage,
             should_relaunch_kpi_computation=should_relaunch_kpi_computation,
             use_honeypot=use_honeypot,

src/kili/use_cases/project/project.py

@@ -121,10 +121,6 @@ def update_properties_in_project(
         input_type: Optional[InputType] = None,
         json_interface: Optional[Dict] = None,
         min_consensus_size: Optional[int] = None,
-        number_of_assets: Optional[int] = None,
-        number_of_skipped_assets: Optional[int] = None,
-        number_of_remaining_assets: Optional[int] = None,
-        number_of_reviewed_assets: Optional[int] = None,
         review_coverage: Optional[int] = None,
         should_relaunch_kpi_computation: Optional[bool] = None,
         title: Optional[str] = None,
@@ -187,10 +183,6 @@ def update_properties_in_project(
             metadata_types=metadata_types,
             metadata_properties=metadata_properties,
             min_consensus_size=min_consensus_size,
-            number_of_assets=number_of_assets,
-            number_of_skipped_assets=number_of_skipped_assets,
-            number_of_remaining_assets=number_of_remaining_assets,
-            number_of_reviewed_assets=number_of_reviewed_assets,
             review_coverage=review_coverage,
             should_auto_assign=should_auto_assign,
             should_relaunch_kpi_computation=should_relaunch_kpi_computation,

tests/integration/presentation/test_project.py

@@ -63,11 +63,7 @@ def test_when_updating_project_then_it_returns_updated_project(mocker: pytest_mo
                 "instructions": None,
                 "jsonInterface": None,
                 "minConsensusSize": None,
-                "numberOfAssets": None,
                 "rules": None,
-                "numberOfSkippedAssets": None,
-                "numberOfRemainingAssets": None,
-                "numberOfReviewedAssets": None,
                 "reviewCoverage": 42,
                 "shouldAutoAssign": None,
                 "shouldRelaunchKpiComputation": None,

tests/integration/use_cases/test_project.py

@@ -199,10 +199,6 @@ def mocked_update_properties_in_project(
         input_type=None,
         json_interface=None,
         min_consensus_size=None,
-        number_of_assets=None,
-        number_of_skipped_assets=None,
-        number_of_remaining_assets=None,
-        number_of_reviewed_assets=None,
         review_coverage=None,
         should_relaunch_kpi_computation=None,
         use_honeypot=None,