Refactor NEAR transaction handling in FireblocksService (#251)

* Refactor NEAR transaction handling in FireblocksService

- Renamed  to  for clarity and updated its implementation to create transactions without waiting for completion.
- Introduced a new method  to handle transaction completion separately.
- Added a new  method that combines the creation and completion steps for NEAR transactions.
- Updated documentation comments to reflect the changes in method functionality.

* bump version

Author: menefrego15

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@kilnfi/sdk",
-  "version": "4.2.20",
+  "version": "4.2.21",
   "autor": "Kiln <[email protected]> (https://kiln.fi)",
   "license": "BUSL-1.1",
   "description": "JavaScript sdk for Kiln API",

src/fireblocks.ts

@@ -183,9 +183,6 @@ export class FireblocksService {
     };
   }
 
-  /**
-   * Sign a ATOM transaction on Fireblocks
-   */
   /**
    * Create an ATOM transaction in Fireblocks without waiting for completion
    */
@@ -1449,17 +1446,14 @@ export class FireblocksService {
   }
 
   /**
-   * Sign a Near transaction on Fireblocks
+   * Create a NEAR transaction in Fireblocks without waiting for completion
    */
-  async signNearTx(
+  async createNearTx(
     integration: FireblocksIntegration,
     tx: components['schemas']['NEARTx'],
     assetId: 'NEAR_TEST' | 'NEAR',
     note?: string,
-  ): Promise<{
-    signed_tx: { data: components['schemas']['NEARSignedTx'] };
-    fireblocks_tx: TransactionResponse;
-  }> {
+  ): Promise<TransactionResponse> {
     const payload = {
       rawMessageData: {
         messages: [
@@ -1472,8 +1466,23 @@ export class FireblocksService {
 
     const fbSigner = this.getSigner(integration);
     const fbNote = note ? note : 'NEAR tx from @kilnfi/sdk';
-    const fbTx = await fbSigner.sign(payload, assetId, fbNote);
-    const signature = fbTx.signedMessages?.[0]?.signature?.fullSig;
+    return await fbSigner.createTransaction(payload, assetId, fbNote);
+  }
+
+  /**
+   * Wait for a NEAR transaction to complete and prepare it for broadcast
+   */
+  async waitForNearTxCompletion(
+    integration: FireblocksIntegration,
+    tx: components['schemas']['NEARTx'],
+    fbTx: TransactionResponse,
+  ): Promise<{
+    signed_tx: { data: components['schemas']['NEARSignedTx'] };
+    fireblocks_tx: TransactionResponse;
+  }> {
+    const fbSigner = this.getSigner(integration);
+    const completedTx = await fbSigner.waitForTxCompletion(fbTx);
+    const signature = completedTx.signedMessages?.[0]?.signature?.fullSig;
 
     if (!signature) {
       throw new Error(ERRORS.MISSING_SIGNATURE);
@@ -1496,6 +1505,22 @@ export class FireblocksService {
     };
   }
 
+  /**
+   * Sign a NEAR transaction on Fireblocks (combines createNearTx and waitForNearTxCompletion)
+   */
+  async signNearTx(
+    integration: FireblocksIntegration,
+    tx: components['schemas']['NEARTx'],
+    assetId: 'NEAR_TEST' | 'NEAR',
+    note?: string,
+  ): Promise<{
+    signed_tx: { data: components['schemas']['NEARSignedTx'] };
+    fireblocks_tx: TransactionResponse;
+  }> {
+    const fbTx = await this.createNearTx(integration, tx, assetId, note);
+    return await this.waitForNearTxCompletion(integration, tx, fbTx);
+  }
+
   /**
    * Sign a Trx transaction on Fireblocks
    */