Merge branch 'feature/refactor_string' of https://github.com/kimkulling/cppcore into feature/refactor_string

kullingk · kullingk · commit 5c10a831e267 · 2025-06-27T16:19:44.000+02:00
diff --git a/include/cppcore/Common/TStringBase.h b/include/cppcore/Common/TStringBase.h
@@ -158,7 +158,7 @@ inline void TStringBase<T>::clear() {
         mStringBuffer = nullptr;
         mCapacity = InitSize;
     }
-    mSize = 0;
+    reset();
 }
 
 template <class T>
@@ -184,8 +184,12 @@ inline bool TStringBase<T>::operator == (const TStringBase<T> &rhs) const {
         return false;
     }
 
+    if (mHashId != rhs.mHashId) {
+        return false;
+    }
     
-    return mHashId == rhs.mHashId;
+    // Fallback to actual comparison in case of hash collision
+    return memcmp(c_str(), rhs.c_str(), mSize * sizeof(T)) == 0;
 }
 
 template <class T>

Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ inline void TStringBase<T>::clear() {`
`158`	`158`	`mStringBuffer = nullptr;`
`159`	`159`	`mCapacity = InitSize;`
`160`	`160`	`}`
`161`		`- mSize = 0;`
	`161`	`+ reset();`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`template <class T>`
`@@ -184,8 +184,12 @@ inline bool TStringBase<T>::operator == (const TStringBase<T> &rhs) const {`
`184`	`184`	`return false;`
`185`	`185`	`}`
`186`	`186`
	`187`	`+ if (mHashId != rhs.mHashId) {`
	`188`	`+ return false;`
	`189`	`+ }`
`187`	`190`
`188`		`- return mHashId == rhs.mHashId;`
	`191`	`+ // Fallback to actual comparison in case of hash collision`
	`192`	`+ return memcmp(c_str(), rhs.c_str(), mSize * sizeof(T)) == 0;`
`189`	`193`	`}`
`190`	`194`
`191`	`195`	`template <class T>`