Skip to content

Commit 3fbbe5e

Browse files
authored
Merge pull request #78 from krishty/fix-buffer-overflows
Fixed issue with clang complaining about sprintf being depreciated
2 parents dee99cc + 4ddbd2c commit 3fbbe5e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

code/OpenDDLExport.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ bool OpenDDLExport::writeValueType(Value::ValueType type, size_t numItems, std::
225225
statement += "[";
226226
char buffer[256];
227227
::memset(buffer, '\0', 256 * sizeof(char));
228-
sprintf(buffer, "%d", static_cast<int>(numItems));
228+
snprintf(buffer, sizeof(buffer), "%d", static_cast<int>(numItems));
229229
statement += buffer;
230230
statement += "]";
231231
}
@@ -256,15 +256,15 @@ bool OpenDDLExport::writeValue(Value *val, std::string &statement) {
256256
std::stringstream stream;
257257
char buffer[256];
258258
::memset(buffer, '\0', 256 * sizeof(char));
259-
sprintf(buffer, "%d", val->getInt16());
259+
snprintf(buffer, sizeof(buffer), "%d", val->getInt16());
260260
statement += buffer;
261261
} break;
262262
case Value::ValueType::ddl_int32: {
263263
std::stringstream stream;
264264
char buffer[256];
265265
::memset(buffer, '\0', 256 * sizeof(char));
266266
const int i = static_cast<int>(val->getInt32());
267-
sprintf(buffer, "%d", i);
267+
snprintf(buffer, sizeof(buffer), "%d", i);
268268
statement += buffer;
269269
} break;
270270
case Value::ValueType::ddl_int64: {

0 commit comments

Comments
 (0)