fix: improve error state and redirect handling

Author: daniel-kinde

src/handlers/callback.ts

@@ -18,23 +18,19 @@ export const callback = async (routerClient: RouterClient) => {
     if (errorParam?.toLowerCase() === "login_link_expired") {
       const reauthState = routerClient.getSearchParam("reauth_state");
       if (reauthState) {
-        const decodedAuthState = atob(reauthState);
         try {
-          const reauthState = JSON.parse(decodedAuthState);
-          if (reauthState) {
-            const urlParams = new URLSearchParams(reauthState);
+          const decodedAuthState = atob(reauthState);
+          const parsedReauthState = JSON.parse(decodedAuthState);
+          if (parsedReauthState) {
+            const urlParams = new URLSearchParams(parsedReauthState);
             const loginRoute = new URL(
               `${config.redirectURL}${config.apiPath}/${routes.login}`,
             );
             loginRoute.search = urlParams.toString();
             return routerClient.redirect(loginRoute.toString());
           }
-        } catch (ex) {
-          throw new Error(
-            ex instanceof Error
-              ? ex.message
-              : "Unknown Error parsing reauth state",
-          );
+        } catch {
+          return redirectToLogin(routerClient);
         }
       }
       return redirectToLogin(routerClient);