Skip to content

Commit 81b4518

Browse files
committed
Wrap KindeSingletonTest cleanup in try/finally to prevent singleton state leaking on failure
1 parent 9317b13 commit 81b4518

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

kinde-j2ee/src/test/java/com/kinde/servlet/KindeSingletonTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,16 @@ public static Test suite()
3333
*/
3434
public void testApp()
3535
{
36-
// Initialize Guice with test modules
3736
KindeEnvironmentSingleton.init(KindeEnvironmentSingleton.State.TEST);
3837
KindeGuiceSingleton.init(
3938
new KindeJ2eeGuiceTestModule(),
4039
new KindeTokenGuiceTestModule());
41-
42-
KindeSingleton singleton = KindeSingleton.getInstance();
43-
assertTrue( true );
44-
45-
KindeGuiceSingleton.fin();
46-
KindeEnvironmentSingleton.fin();
40+
try {
41+
KindeSingleton singleton = KindeSingleton.getInstance();
42+
assertTrue( true );
43+
} finally {
44+
KindeGuiceSingleton.fin();
45+
KindeEnvironmentSingleton.fin();
46+
}
4747
}
4848
}

0 commit comments

Comments
 (0)