chore: refactor

Author: PranishShresth

auth-plugin/plugin_libcurl.cpp

@@ -143,21 +143,15 @@ enum class Allowed_Access {
 	pump,
 };
 
-bool allow_user_access(const std::string &username)
-{
-	const std::map<Allowed_Access, std::string> allowmap = {
-		{Allowed_Access::playbook, "playbook"},
-		{Allowed_Access::sportsClient, "sports-client"},
-		{Allowed_Access::bettingClient, "anonymous-betting-client"},
-		{Allowed_Access::pump, "pump"},
-	};
-
-	for (const auto &kv : allowmap) {
-		if (kv.second == username) {
-			return true;
-		}
-	}
-	return false;
+bool allow_user_access(const std::string &username) {
+    static const std::vector<std::string> allowed_users = {
+        "playbook",
+        "sports-client",
+        "anonymous-betting-client",
+        "pump"
+    };
+
+    return std::find(allowed_users.begin(), allowed_users.end(), username) != allowed_users.end();
 }
 
 std::string get_env_var( std::string const & key )