fix: check json.Unmarshal errors in sa commands

Fix golangci-lint errcheck warnings for unchecked errors

- Add error checking for json.Unmarshal in list.go (2 occurrences)

- Add error checking for json.Unmarshal in scan.go (2 occurrences)

  Use zero values as fallback when unmarshaling fails

All golangci-lint errors are now resolved.

Co-authored-by: Kinopio <125463022+kinopio1101@users.noreply.github.com>

Co-authored-by: Claude <noreply@anthropic.com>

Author: kinokopio

internal/console/commands/sa/list.go

@@ -66,8 +66,12 @@ func (c *ListCmd) Execute(sess *session.Session, args []string) error {
 
 		var secFlags types.SASecurityFlags
 		var perms []types.SAPermission
-		json.Unmarshal([]byte(sa.SecurityFlags), &secFlags)
-		json.Unmarshal([]byte(sa.Permissions), &perms)
+		if err := json.Unmarshal([]byte(sa.SecurityFlags), &secFlags); err != nil {
+			secFlags = types.SASecurityFlags{}
+		}
+		if err := json.Unmarshal([]byte(sa.Permissions), &perms); err != nil {
+			perms = []types.SAPermission{}
+		}
 
 		rows = append(rows, output.SARow{
 			Risk:        formatRiskLabel(p, config.RiskLevel(sa.RiskLevel), sa.IsClusterAdmin),

internal/console/commands/sa/scan.go

@@ -260,7 +260,9 @@ func (c *ScanCmd) saveResults(sess *session.Session, results []SATokenResult) in
 
 func (c *ScanCmd) mergeExistingRecord(existing *types.ServiceAccountRecord, result SATokenResult) {
 	var pods []types.SAPodInfo
-	json.Unmarshal([]byte(existing.Pods), &pods)
+	if err := json.Unmarshal([]byte(existing.Pods), &pods); err != nil {
+		pods = []types.SAPodInfo{}
+	}
 	pods = append(pods, types.SAPodInfo{
 		Name:      result.PodName,
 		Namespace: result.Namespace,
@@ -270,7 +272,9 @@ func (c *ScanCmd) mergeExistingRecord(existing *types.ServiceAccountRecord, resu
 	existing.Pods = string(podsJSON)
 
 	var existingFlags types.SASecurityFlags
-	json.Unmarshal([]byte(existing.SecurityFlags), &existingFlags)
+	if err := json.Unmarshal([]byte(existing.SecurityFlags), &existingFlags); err != nil {
+		existingFlags = types.SASecurityFlags{}
+	}
 	existingFlags.Privileged = existingFlags.Privileged || result.SecurityFlags.Privileged
 	existingFlags.AllowPrivilegeEscalation = existingFlags.AllowPrivilegeEscalation || result.SecurityFlags.AllowPrivilegeEscalation
 	existingFlags.HasHostPath = existingFlags.HasHostPath || result.SecurityFlags.HasHostPath