Merge pull request opencontainers#585 from q384566678/setconfig-fix

validation: Add error judgment to SetConfig

Author: liangchenye

validation/hooks.go

@@ -81,8 +81,7 @@ func main() {
 				return err
 			}
 			g.SetProcessArgs([]string{"true"})
-			r.SetConfig(g)
-			return nil
+			return r.SetConfig(g)
 		},
 		PreDelete: func(r *util.Runtime) error {
 			util.WaitingForStatus(*r, util.LifecycleStatusStopped, time.Second*10, time.Second)

validation/poststart.go

@@ -37,8 +37,7 @@ func main() {
 				return err
 			}
 			g.SetProcessArgs([]string{"sh", "-c", fmt.Sprintf("echo 'process called' >> %s", "/output")})
-			r.SetConfig(g)
-			return nil
+			return r.SetConfig(g)
 		},
 		PostCreate: func(r *util.Runtime) error {
 			outputData, err := ioutil.ReadFile(output)

validation/poststop.go

@@ -38,8 +38,7 @@ func main() {
 				return err
 			}
 			g.SetProcessArgs([]string{"sh", "-c", fmt.Sprintf("echo 'process called' >> %s", "/output")})
-			r.SetConfig(g)
-			return nil
+			return r.SetConfig(g)
 		},
 		PostCreate: func(r *util.Runtime) error {
 			outputData, err := ioutil.ReadFile(output)

validation/prestart.go

@@ -36,8 +36,7 @@ func main() {
 				return err
 			}
 			g.SetProcessArgs([]string{"sh", "-c", fmt.Sprintf("echo 'process called' >> %s", "/output")})
-			r.SetConfig(g)
-			return nil
+			return r.SetConfig(g)
 		},
 		PostCreate: func(r *util.Runtime) error {
 			outputData, err := ioutil.ReadFile(output)

validation/start.go

@@ -32,7 +32,10 @@ func main() {
 	}
 	g := util.GetDefaultGenerator()
 	g.SetProcessArgs([]string{"sh", "-c", fmt.Sprintf("echo 'process called' >> %s", "/output")})
-	r.SetConfig(g)
+	err = r.SetConfig(g)
+	if err != nil {
+		util.Fatal(err)
+	}
 	output := filepath.Join(bundleDir, g.Spec().Root.Path, "output")
 
 	// start without id
@@ -84,7 +87,10 @@ func main() {
 	}
 
 	g.Spec().Process = nil
-	r.SetConfig(g)
+	err = r.SetConfig(g)
+	if err != nil {
+		util.Fatal(err)
+	}
 	err = r.Create()
 	if err != nil {
 		util.Fatal(err)