Merge pull request kubernetes-sigs#749 from JanHolger/fix-panic-without-mtls

k8s-ci-robot · ipochi · commit a2cdfb42c11b · 2025-08-21T00:14:03.000Z
Fix panic when mtls is disabled (cherry picked from commit e135055)
diff --git a/pkg/server/tunnel.go b/pkg/server/tunnel.go
@@ -40,7 +40,7 @@ func (t *Tunnel) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	defer metrics.Metrics.HTTPConnectionDec()
 
 	klog.V(2).InfoS("Received request for host", "method", r.Method, "host", r.Host, "userAgent", r.UserAgent())
-	if r.TLS != nil {
+	if r.TLS != nil && len(r.TLS.PeerCertificates) > 0 {
 		klog.V(2).InfoS("TLS", "commonName", r.TLS.PeerCertificates[0].Subject.CommonName)
 	}
 	if r.Method != http.MethodConnect {

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ func (t Tunnel) ServeHTTP(w http.ResponseWriter, r http.Request) {`
`40`	`40`	`defer metrics.Metrics.HTTPConnectionDec()`
`41`	`41`
`42`	`42`	`klog.V(2).InfoS("Received request for host", "method", r.Method, "host", r.Host, "userAgent", r.UserAgent())`
`43`		`- if r.TLS != nil {`
	`43`	`+ if r.TLS != nil && len(r.TLS.PeerCertificates) > 0 {`
`44`	`44`	`klog.V(2).InfoS("TLS", "commonName", r.TLS.PeerCertificates[0].Subject.CommonName)`
`45`	`45`	`}`
`46`	`46`	`if r.Method != http.MethodConnect {`