Skip to content

Commit 0034e07

Browse files
marquizhaircommander
authored andcommitted
KEP-4033: update PRR questionnaire
In response to feedback from johnbelamaric.
1 parent fcda1cf commit 0034e07

File tree

1 file changed

+5
-3
lines changed
  • keps/sig-node/4033-group-driver-detection-over-cri

1 file changed

+5
-3
lines changed

keps/sig-node/4033-group-driver-detection-over-cri/README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ You can take a look at one potential example of such test in:
584584
https://github.com/kubernetes/kubernetes/pull/97058/files#diff-7826f7adbc1996a05ab52e3f5f02429e94b68ce6bce0dc534d1be636154fded3R246-R282
585585
-->
586586

587-
TBD.
587+
Unit tests for the feature gate will be written.
588588

589589
### Rollout, Upgrade and Rollback Planning
590590

@@ -617,7 +617,8 @@ What signals should users be paying attention to when the feature is young
617617
that might indicate a serious problem?
618618
-->
619619

620-
N/A.
620+
Nodes being in NotReady state with kubelet logs indicating an error in the
621+
RuntimeConfig CRI request, making kubelet fail to start.
621622

622623
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
623624

@@ -627,7 +628,8 @@ Longer term, we may want to require automated upgrade/rollback tests, but we
627628
are missing a bunch of machinery and tooling and can't do that now.
628629
-->
629630

630-
N/A.
631+
Not planned as there is no persistent state associated with the feature. Manual
632+
testing of the feature gate (in addition to the unit tests) is performed.
631633

632634
###### Is the rollout accompanied by any deprecations and/or removals of features, APIs, fields of API types, flags, etc.?
633635

0 commit comments

Comments
 (0)