Skip to content

Commit 074f26e

Browse files
authored
Merge pull request kubernetes#3118 from wojtek-t/remove_selflink_stable
Graduate RemoveSelfLink to Stable
2 parents 0e91098 + 39af5f9 commit 074f26e

File tree

3 files changed

+30
-7
lines changed

3 files changed

+30
-7
lines changed
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
kep-number: 1164
2+
stable:
3+
approver: "@deads2k"

keps/sig-api-machinery/1164-remove-selflink/README.md

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
- [Design Details](#design-details)
1414
- [Test Plan](#test-plan)
1515
- [Graduation Criteria](#graduation-criteria)
16+
- [GA](#ga)
1617
- [Upgrade / Downgrade Strategy](#upgrade--downgrade-strategy)
1718
- [Version Skew Strategy](#version-skew-strategy)
1819
- [Production Readiness Review Questionnaire](#production-readiness-review-questionnaire)
@@ -176,6 +177,23 @@ require more explanation.
176177

177178
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/
178179

180+
#### GA
181+
182+
- Feature remained disabled by default for 4 releases
183+
- Confirmed that feature gate is disabled by default in cloud-providers:
184+
GKE, OpenShift, EKS and AKS
185+
- Sweep of RemoveSelfLink in [grep app](https://grep.app)
186+
- The following issues were opened for repos explicitly setting `RemoveSelfLink=false`:
187+
- [ubuntu/microk8s](https://github.com/ubuntu/microk8s/issues/2829)
188+
- [giantnetes-kubernetes](https://github.com/giantswarm/giantnetes-terraform/issues/543)
189+
- [rancher-ceph](https://github.com/vasyakrg/rancher-ceph/issues/2)
190+
- [ansible-role-k8s](https://github.com/PyratLabs/ansible-role-k3s/issues/175)
191+
- The following issues were opened for repos that are vendoring old releases of Kubernetes
192+
that still has feature-gate set to `false`:
193+
- [volano](https://github.com/volcano-sh/volcano/issues/1948)
194+
- [service-catalog](https://github.com/kubernetes-sigs/service-catalog/issues/2909)
195+
- [kube-batch](https://github.com/kubernetes-sigs/kube-batch/issues/958)
196+
179197
### Upgrade / Downgrade Strategy
180198

181199
No specific strategy is required.
@@ -309,6 +327,8 @@ _This section must be completed when targeting beta graduation to a release._
309327

310328
## Implementation History
311329

312-
2019-07-23: KEP merged.
313-
2019-07-24: KEP move to implementable.
314-
v1.16: Released in Alpha
330+
- 2019-07-23: KEP merged.
331+
- 2019-07-24: KEP move to implementable.
332+
- v1.16: Released in Alpha
333+
- v1.20: Released in Beta, enabled by default
334+
- 2022-01-10: KEP updated to target GA in v1.24

keps/sig-api-machinery/1164-remove-selflink/kep.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,22 @@ approvers:
1414
prr-approvers:
1515
- "@deads2k"
1616
creation-date: 2019-07-11
17-
last-updated: 2019-07-24
17+
last-updated: 2022-01-10
1818
status: implementable
1919

2020
# The target maturity stage in the current dev cycle for this KEP.
21-
stage: beta
21+
stage: stable
2222

2323
# The most recent milestone for which work toward delivery of this KEP has been
2424
# done. This can be the current (upcoming) milestone, if it is being actively
2525
# worked on.
26-
latest-milestone: "v1.20"
26+
latest-milestone: "v1.24"
2727

2828
# The milestone at which this feature was, or is targeted to be, at each stage.
2929
milestone:
3030
alpha: "v1.16"
3131
beta: "v1.20"
32-
stable: "v1.21"
32+
stable: "v1.24"
3333

3434
# The following PRR answers are required at alpha release
3535
# List the feature gate name and the components for which it must be enabled

0 commit comments

Comments
 (0)