Skip to content

Commit 0bbed62

Browse files
committed
KEP-1965: add metrics for poststarthook/start-kube-apiserver-identity-lease-garbage-collector in PRR
Signed-off-by: Andrew Sy Kim <[email protected]>
1 parent c7bb7da commit 0bbed62

File tree

1 file changed

+2
-1
lines changed
  • keps/sig-api-machinery/1965-kube-apiserver-identity

1 file changed

+2
-1
lines changed

keps/sig-api-machinery/1965-kube-apiserver-identity/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,6 +234,7 @@ found using the `k8s.io/component=kube-apiserver` label.
234234

235235
Recently added [healthcheck metrics for apiserver](https://github.com/kubernetes/kubernetes/pull/112741), which includes
236236
the health of the post start hook can be used to inform rollback, specifically `kubernetes_healthcheck{poststarthook/start-kube-apiserver-identity-lease-controller}`
237+
and `kubernetes_healthcheck{poststarthook/start-kube-apiserver-identity-lease-garbage-collector}`
237238

238239
###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?
239240

@@ -273,7 +274,7 @@ All leases owned by kube-apiservers can be found using the `k8s.io/component=kub
273274

274275
- [X] Metrics
275276
- Metric name: kubernetes_healthcheck
276-
- [Optional] Aggregation method: name="poststarthook/start-kube-apiserver-identity-lease-controller"
277+
- [Optional] Aggregation method: name="poststarthook/start-kube-apiserver-identity-lease-controller", name="poststarthook/start-kube-apiserver-identity-lease-garbage-collector"
277278
- Components exposing the metric: kube-apiserver
278279

279280
###### Are there any missing metrics that would be useful to have to improve observability of this feature?

0 commit comments

Comments
 (0)