You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Added E2E tests to validate workloads move successfully to another running node when a node is shutdown: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/non_graceful_node_shutdown.go
174
-
* Feature gate for `NodeOutOfServiceVolumeDetach` is disabled, feature is not active.
175
174
* Feature gate for `NodeOutOfServiceVolumeDetach` is enabled. Add `out-of-service` taint after node is shutdown:
176
175
* Verify workloads are moved to another node successfully.
177
176
* Verify the `out-of-service` taint is removed after the shutdown node is cleaned up.
@@ -336,7 +335,8 @@ the health of the service?**
336
335
- Metric name: We can add new metrics deleting_pods_total, deleting_pods_error_total
337
336
in Pod GC Controller.
338
337
For Attach Detach Controller, there's already a metric:
339
-
attachdetach_controller_forced_detaches.
338
+
attachdetach_controller_forced_detaches. We could keep it for force detach
339
+
by timeout and add a new metric attachdetach_controller_forced_detaches_taint.
340
340
-[Optional] Aggregation method:
341
341
- Components exposing the metric:
342
342
-[ ] Other (treat as last resort)
@@ -355,8 +355,9 @@ the health of the service?**
355
355
The failover should always happen if the feature gate is enabled, the taint
356
356
is applied, and there are other running nodes.
357
357
We can also check the deleting_pods_total, deleting_pods_error_total metrics
358
-
in Pod GC Controller and the attachdetach_controller_forced_detaches metric
359
-
in the Attach Detach Controller.
358
+
in Pod GC Controller and the attachdetach_controller_forced_detaches and
359
+
attachdetach_controller_forced_detaches_taint metric in the Attach Detach
360
+
Controller.
360
361
361
362
***Are there any missing metrics that would be useful to have to improve observability
362
363
of this feature?**
@@ -421,7 +422,7 @@ previous answers based on experience in the field._
421
422
422
423
***Will enabling / using this feature result in any new calls to the cloud
423
424
provider?**
424
-
No.
425
+
Volume detach/attach could trigger cloud provider calls.
425
426
426
427
***Will enabling / using this feature result in increasing size or count of
0 commit comments