Skip to content

Commit 0c05017

Browse files
committed
Address review comments
1 parent f055550 commit 0c05017

File tree

1 file changed

+6
-5
lines changed
  • keps/sig-storage/2268-non-graceful-shutdown

1 file changed

+6
-5
lines changed

keps/sig-storage/2268-non-graceful-shutdown/README.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,6 @@ https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/non_gracef
171171
#### E2E tests
172172

173173
* Added E2E tests to validate workloads move successfully to another running node when a node is shutdown: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/non_graceful_node_shutdown.go
174-
* Feature gate for `NodeOutOfServiceVolumeDetach` is disabled, feature is not active.
175174
* Feature gate for `NodeOutOfServiceVolumeDetach` is enabled. Add `out-of-service` taint after node is shutdown:
176175
* Verify workloads are moved to another node successfully.
177176
* Verify the `out-of-service` taint is removed after the shutdown node is cleaned up.
@@ -336,7 +335,8 @@ the health of the service?**
336335
- Metric name: We can add new metrics deleting_pods_total, deleting_pods_error_total
337336
in Pod GC Controller.
338337
For Attach Detach Controller, there's already a metric:
339-
attachdetach_controller_forced_detaches.
338+
attachdetach_controller_forced_detaches. We could keep it for force detach
339+
by timeout and add a new metric attachdetach_controller_forced_detaches_taint.
340340
- [Optional] Aggregation method:
341341
- Components exposing the metric:
342342
- [ ] Other (treat as last resort)
@@ -355,8 +355,9 @@ the health of the service?**
355355
The failover should always happen if the feature gate is enabled, the taint
356356
is applied, and there are other running nodes.
357357
We can also check the deleting_pods_total, deleting_pods_error_total metrics
358-
in Pod GC Controller and the attachdetach_controller_forced_detaches metric
359-
in the Attach Detach Controller.
358+
in Pod GC Controller and the attachdetach_controller_forced_detaches and
359+
attachdetach_controller_forced_detaches_taint metric in the Attach Detach
360+
Controller.
360361

361362
* **Are there any missing metrics that would be useful to have to improve observability
362363
of this feature?**
@@ -421,7 +422,7 @@ previous answers based on experience in the field._
421422

422423
* **Will enabling / using this feature result in any new calls to the cloud
423424
provider?**
424-
No.
425+
Volume detach/attach could trigger cloud provider calls.
425426

426427
* **Will enabling / using this feature result in increasing size or count of
427428
the existing API objects?**

0 commit comments

Comments
 (0)