Skip to content

Commit 0e2da7a

Browse files
authored
Merge pull request kubernetes#3799 from ahg-g/ahg-mutable
Updated mutable scheduling directives to adhere to the new test template
2 parents 2108074 + fa9fab6 commit 0e2da7a

File tree

1 file changed

+19
-3
lines changed
  • keps/sig-scheduling/2926-job-mutable-scheduling-directives

1 file changed

+19
-3
lines changed

keps/sig-scheduling/2926-job-mutable-scheduling-directives/README.md

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,9 @@ tags, and then generate with `hack/update-toc.sh`.
8989
- [Risks and Mitigations](#risks-and-mitigations)
9090
- [Design Details](#design-details)
9191
- [Test Plan](#test-plan)
92+
- [Unit tests](#unit-tests)
93+
- [Integration tests](#integration-tests)
94+
- [e2e tests](#e2e-tests)
9295
- [Graduation Criteria](#graduation-criteria)
9396
- [Beta](#beta)
9497
- [GA](#ga)
@@ -334,9 +337,22 @@ proposal will be implemented, this is the place to discuss them.
334337
### Test Plan
335338

336339
- Unit and integration tests veryfing that:
337-
- pod template's node affinity, node selector, tolerations, annotations and labels not mutable for jobs that have been unsuspended before
338-
- pod template's node affinity, node selector tolerations, annotations or labels not mutable for apps other than jobs
339-
- job controller observes the update and creates pods with the new scheduling directives
340+
- pod template's node affinity, node selector, tolerations, annotations and labels not mutable for jobs that have been unsuspended before.
341+
- pod template's node affinity, node selector tolerations, annotations or labels not mutable for apps other than jobs.
342+
- job controller observes the update and creates pods with the new scheduling directives.
343+
344+
#### Unit tests
345+
346+
- `k8s.io/kubernetes/pkg/registry/batch/job/`: `1/30/2023` - `76.8%`
347+
348+
#### Integration tests
349+
350+
Available under [Job integrations tests](https://github.com/kubernetes/kubernetes/blob/457341c3d408097025af5a9b6f5917439c0debdd/test/integration/job/job_test.go#L1397)
351+
352+
#### e2e tests
353+
354+
Integration tests offer enough coverage.
355+
340356

341357
<!--
342358
**Note:** *Not required until targeted at a release.*

0 commit comments

Comments
 (0)